Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resources: Make Text compatible with compose #47

Open
osipxd opened this issue Jan 28, 2022 · 1 comment
Open

resources: Make Text compatible with compose #47

osipxd opened this issue Jan 28, 2022 · 1 comment

Comments

@osipxd
Copy link
Collaborator

osipxd commented Jan 28, 2022 •
edited
Loading

Text keyword used for composable function, so we should rename this class to make it usable from Compose.
Also Text.get should receive Resources instead of Context as a parameter. Maybe, we should also provide an extension to easily get Text value in Compose.
@osipxd osipxd mentioned this issue Mar 26, 2022
Closed
@osipxd
Copy link
Collaborator Author

osipxd commented Mar 2, 2023

Text should also be annotated as @Immutable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

draft: resources-ktx: Make Text compatible with compose RedMadRobot/gears-android
1 participant
@osipxd