Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue when windows username contains dots #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yarix
Copy link

@yarix yarix commented Jul 26, 2022

the windows user can contain dots which are not valid for namespace creation.
for example with user name "first.last", the setup script fails with:

Creating namespace 'first.last-dev' ...
The Namespace "first.last-dev" is invalid: metadata.name: Invalid value: "first.last-dev": a lowercase RFC 1123 label must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name',  or '123-abc', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?')
Error while creating namespace first.last-dev.

the solution here is to replace every '.' with '-'

the windows user can contain dots which are not valid for namespace creation.
for example with user name "first.last", the setup script fails with:
```
Creating namespace 'first.last-dev' ...
The Namespace "first.last-dev" is invalid: metadata.name: Invalid value: "first.last-dev": a lowercase RFC 1123 label must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name',  or '123-abc', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?')
Error while creating namespace first.last-dev.
```

the solution here is to replace every '.' with '-'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant