Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OLD] Draft: Do not run upstream tests as root #213

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ansasaki
Copy link
Contributor

The goal is to make the tests compatible with keylime/keylime#1132 in which the upstream tests are not required to be executed as root anymore.

The upstream tests do not need to run as root anymore.

Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
@kkaarreell
Copy link
Collaborator

kkaarreell commented Oct 21, 2022

HI @ansasaki , are those missing dependencies something that has been newly added to keylime? Or maybe a package set installed by default on a test system has changed.

EDIT: It rather looks like a bug in a test case code

usr/local/lib64/python3.10/site-packages/coverage/inorout.py:497: CoverageWarning: Already imported a file that will be measured: /usr/local/bin/coverage (already-imported)
  self.warn(msg, slug="already-imported")
Traceback (most recent call last):
  File "/tmp/tmp.3TnLDQs4Wl/test/test_restful.py", line 46, in <module>
    import scripts.convert_config as convert
ModuleNotFoundError: No module named 'scripts'

@ansasaki
Copy link
Contributor Author

HI @ansasaki , are those missing dependencies something that has been newly added to keylime? Or maybe a package set installed by default on a test system has changed.

There are no new dependencies, it is just that the upstream test suite were not installing the dependencies needed to build the rust agent, but now they are being installed.

EDIT: It rather looks like a bug in a test case code

Yes, this is not finished yet.

@kkaarreell kkaarreell changed the title Draft: Do not run upstream tests as root [OLD] Draft: Do not run upstream tests as root Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants