Files that changed from the base of the PR and between 7ed6766 and b8e8cf5.

• src/main/java/dev/redstudio/valkyrie/Valkyrie.java (1 hunks)
• src/main/java/dev/redstudio/valkyrie/config/ValkyrieConfig.java (1 hunks)
• src/main/resources/assets/valkyrie/lang/en_us.lang (1 hunks)

src/main/java/dev/redstudio/valkyrie/Valkyrie.java (1)

51-52: LGTM! Consider adding a comment and logging.

The implementation correctly introduces the config option for checking the Java version, aligning with the PR objectives. It preserves the default behavior while allowing users to disable the check if needed.

Consider the following minor improvements:

1. Add a comment explaining the purpose of this configuration option:

+   // Allow users to disable Java version check if they prefer not to receive warnings
    if (ValkyrieConfig.general.javaVersionCheck)
        new Thread(JvmCheckUtil::checkJavaVersion).start();

2. Consider adding logging when the check is skipped:

    if (ValkyrieConfig.general.javaVersionCheck)
        new Thread(JvmCheckUtil::checkJavaVersion).start();
+   else
+       LOGGER.info("Java version check skipped due to user configuration.");

To ensure ValkyrieConfig is properly initialized before this point, let's check its usage:

src/main/java/dev/redstudio/valkyrie/config/ValkyrieConfig.java (1)

31-33: Verify the implementation of the Java version check logic.

The configuration option has been added successfully. However, to ensure full functionality, we should verify that the Java version check logic properly utilizes this new configuration option.

Let's search for the implementation of the Java version check:

This will help us confirm that the new configuration option is being used correctly in the actual version check logic.

✅ Verification successful

Verify the Java version check implementation within Valkyrie.java.

To ensure that the javaVersionCheck configuration option effectively controls the Java version verification logic, we need to inspect its implementation in Valkyrie.java.

---

Verify the implementation of checkJavaVersion in JvmCheckUtil.

To ensure that the Java version check operates correctly, we need to inspect the checkJavaVersion method within the JvmCheckUtil class.

---

Retrieve the implementation of checkJavaVersion in JvmCheckUtil.java for verification.

To ensure that the Java version check operates correctly, we need to inspect the full implementation of the checkJavaVersion method within the JvmCheckUtil class.

---

Retrieve the complete implementation of checkJavaVersion in JvmCheckUtil.java for thorough verification.

To ensure that the Java version check functions as intended, we need to inspect the entire checkJavaVersion method within the JvmCheckUtil class.

---

Java version check implementation verified.

The javaVersionCheck configuration option is correctly utilized to conditionally initiate the Java version verification. The checkJavaVersion method effectively performs the necessary checks for JVM architecture and version compliance.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Search for the implementation of the Java version check logic

# Test: Look for Java version check implementation
rg --type java -i "java\s+version\s+check|javaVersionCheck"

Length of output: 277

---

Script:

#!/bin/bash
# Description: Extract the code block where javaVersionCheck is used in Valkyrie.java

# Search for the if statement using javaVersionCheck and include 5 lines of context after the match
rg --type java -A 5 'if\s*\(.*javaVersionCheck.*\)' src/main/java/dev/redstudio/valkyrie/Valkyrie.java

Length of output: 324

---

Script:

#!/bin/bash
# Description: Locate the implementation of checkJavaVersion in JvmCheckUtil

rg --type java 'void\s+checkJavaVersion\s*\(' src/main/java/dev/redstudio/valkyrie/

Length of output: 191

---

Script:

#!/bin/bash
# Description: Extract the full implementation of checkJavaVersion in JvmCheckUtil.java

# Extract the checkJavaVersion method with 10 lines of context after the method signature to capture its implementation
rg --type java -A 10 'public\s+static\s+void\s+checkJavaVersion\s*\(' src/main/java/dev/redstudio/valkyrie/utils/JvmCheckUtil.java

Length of output: 670

---

Script:

#!/bin/bash
# Description: Extract the full implementation of checkJavaVersion in JvmCheckUtil.java

# Extract the entire checkJavaVersion method by capturing lines until the closing brace
rg --type java -A 20 'public\s+static\s+void\s+checkJavaVersion\s*\(' src/main/java/dev/redstudio/valkyrie/utils/JvmCheckUtil.java

Length of output: 1260