Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite RDS homepage tests using expect-puppeteer #15

Open
whyDontI opened this issue Feb 6, 2022 · 4 comments
Open

rewrite RDS homepage tests using expect-puppeteer #15

whyDontI opened this issue Feb 6, 2022 · 4 comments
Assignees

Comments

@whyDontI
Copy link
Contributor

whyDontI commented Feb 6, 2022

https://www.npmjs.com/package/expect-puppeteer

Why do we need it

Writing integration test is very hard, especially when you are testing a Single Page Applications. Data are loaded asynchronously and it is difficult to know exactly when an element will be displayed in the page.

Puppeteer API is great, but it is low level and not designed for integration testing.

This API is designed for integration testing:

  • It will wait for element before running an action
  • It adds additional feature like matching an element using text

Refactor tests for RDS homepage

@rajat-mehra05
Copy link

Sounds good. I don't have any knowledge of testing yet. Can I still take this issue ? I am willing to learn the testing though. This looks good to start with.

@whyDontI
Copy link
Contributor Author

whyDontI commented Feb 6, 2022

@rajat-mehra05 We need to write E2E tests for all the pages across multiple applications.
You can work on them. I am creating some in a minute.

@whyDontI
Copy link
Contributor Author

whyDontI commented Feb 6, 2022

@priyanshk20 Can we quickly have a PR with expect-puppeteer added, and write tests in a separate PR so that others can start working on it ASAP.

@priyanshk20
Copy link

Sure, I will be doing this ASAP.

@whyDontI whyDontI changed the title Add expect-puppeteer and rewrite one of the existing tests using it rewrite RDS homepage tests using expect-puppeteer Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants