Feature: Display User Details for Task Progress Updates #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@AnujChhikara is attempting to deploy a commit to the RDS-Team Team on Vercel. A member of the Team first needs to authorize it. |
vinit717
reviewed
Dec 12, 2024
src/components/taskDetails/ProgressUpdateCard/LatestProgressUpdateCardPresentation.tsx
Outdated
Show resolved
Hide resolved
src/components/taskDetails/ProgressUpdateCard/LatestProgressUpdateCardPresentation.tsx
Show resolved
Hide resolved
VinuB-Dev
reviewed
Dec 13, 2024
src/components/taskDetails/ProgressUpdateCard/LatestProgressUpdateCardPresentation.tsx
Show resolved
Hide resolved
|
Can you please add mobile UI changes recording also. |
VinuB-Dev
reviewed
Dec 13, 2024
src/components/taskDetails/ProgressUpdateCard/ProgressUpdateCardPresentation.tsx
Outdated
Show resolved
Hide resolved
added |
Achintya-Chatterjee
changed the title
Achintya-Chatterjee
requested changes
Dec 17, 2024
src/components/taskDetails/ProgressUpdateCard/LatestProgressUpdateCardPresentation.tsx
Outdated
Show resolved
Hide resolved
src/components/taskDetails/ProgressUpdateCard/ProgressUpdateCardPresentation.tsx
Outdated
Show resolved
Hide resolved
src/components/taskDetails/ProgressUpdateCard/LatestProgressUpdateCard.tsx
Outdated
Show resolved
Hide resolved
src/components/taskDetails/ProgressUpdateCard/latest-progress-update-card.module.scss
Outdated
Show resolved
Hide resolved
src/components/taskDetails/ProgressUpdateCard/latest-progress-update-card.module.scss
Outdated
Show resolved
Hide resolved
pankajjs
reviewed
Dec 19, 2024
pankajjs
reviewed
Dec 19, 2024
src/components/taskDetails/ProgressUpdateCard/LatestProgressUpdateCardPresentation.tsx
Show resolved
Hide resolved
Achintya-Chatterjee
requested changes
Dec 19, 2024
src/components/taskDetails/ProgressUpdateCard/LatestProgressUpdateCardPresentation.tsx
Show resolved
Hide resolved
src/components/taskDetails/ProgressUpdateCard/LatestProgressUpdateCardPresentation.tsx
Show resolved
Hide resolved
Achintya-Chatterjee
previously approved these changes
Dec 21, 2024
vinit717
reviewed
Dec 26, 2024
src/components/taskDetails/ProgressUpdateCard/progress-update-card.module.scss
Outdated
Show resolved
Hide resolved
src/components/taskDetails/ProgressUpdateCard/latest-progress-update-card.module.scss
Outdated
Show resolved
Hide resolved
| @@ -37,6 +45,7 @@ export default function ProgressUpdateCardPresentation({ | |||
| className={ | |||
| styles['progress-update-card__more-less-button'] | |||
| } | |||
| data-testid="progress-update-card-read-more-completed" | |||
| styles['progress-update-card__date-container'] | ||
| <Tooltip | ||
| tooltipPosition={ | ||
| isDevMode |
There was a problem hiding this comment.
Why do you define the CSS here?
There was a problem hiding this comment.
I am passing the css as props as to set the Tooltip position. We are already doing this in the repo with tooltip component.
There was a problem hiding this comment.
Refactor this file as you used too much nesting
Mir-SA
reviewed
Dec 26, 2024
src/components/taskDetails/ProgressUpdateCard/ProgressUpdateCardPresentation.tsx
Outdated
Show resolved
Hide resolved
src/components/taskDetails/ProgressUpdateCard/latest-progress-update-card.module.scss
Outdated
Show resolved
Hide resolved
iamitprakash
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 10 Dec 2024
Developer Name: @AnujChhikara
Issue Ticket Number
Description
This PR implementing a feature to display the details of the user who made the task progress update. The user image will be shown as a clickable link that leads to their user management page, ensuring accountability and transparency in task progress updates. When you hover over the user image it also show their username.
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Updated UI
Mobile UI
Dev Flag Working
Test Coverage
Screenshot 1
Additional Notes
Currently, the progress data does not include the
userDatafield. After discussing with Ankush, we decided to proceed with the frontend changes behind a feature flag. Once this is complete, I will work on the backend implementation.To handle the
?dev=truequery parameter, I utilizeduseRouterin the code. In the tests, I mockeduseRouterto simulate scenarios where thedevquery parameter is set totrueorfalse.Additionally, I wrote extra tests to improve the overall test coverage.