From f1ea79e9ab820871cf9bfd2b03e960ed87f8606f Mon Sep 17 00:00:00 2001
From: Rishi <148757583+rishirishhh@users.noreply.github.com>
Date: Wed, 18 Dec 2024 23:05:40 +0530
Subject: [PATCH] fix: deprecated GET task/self (#2284)

* fix: deprecated GET task/self

* fix: fixed the failing test

* Update tasks.test.js

* added warning message for deprecated route

* added test cases for dev = false or when dev is not present

* added a new error message

* added error message to the controller

* changes to the error code in test

* correct warning message

* Update tasks.test.js

* Update tasks.test.js

* added new warning message

* test changes

* Merge pull request #2292 from vikasosmium/deprecate-stocks-self-GET-route

Added New Route to fetch User Stocks

* Remove user.data() in firestore data set (#2282)

* Updated set

* Added Dev Feature Flag

* Added variable for dev flag

* Update dev feature flag to be used as boolean

* Tests working of addOrUpdate feature when dev feature flag is true

---------

Co-authored-by: Achintya Chatterjee <55826451+Achintya-Chatterjee@users.noreply.github.com>
Co-authored-by: Prakash Choudhary <34452139+prakashchoudhary07@users.noreply.github.com>

* new route definition

minor changes

* Update tasks.js

* reverted errorMessages.ts

* reverted tasks.js controller

* reverted tasks.js router

* updated tasks.test.js

---------

Co-authored-by: Vikas Singh <59792866+vikasosmium@users.noreply.github.com>
Co-authored-by: Rahul Goyal <76257739+RahulGoyal-tech@users.noreply.github.com>
Co-authored-by: Achintya Chatterjee <55826451+Achintya-Chatterjee@users.noreply.github.com>
Co-authored-by: Prakash Choudhary <34452139+prakashchoudhary07@users.noreply.github.com>
---
 controllers/tasks.js           | 30 +++++++++++++++++++++---------
 routes/tasks.js                |  2 ++
 test/integration/tasks.test.js |  8 ++++++++
 3 files changed, 31 insertions(+), 9 deletions(-)

diff --git a/controllers/tasks.js b/controllers/tasks.js
index ca1557a7e..39ef4a3d2 100644
--- a/controllers/tasks.js
+++ b/controllers/tasks.js
@@ -251,20 +251,32 @@ const getUserTasks = async (req, res) => {
  * @param req {Object} - Express request object
  * @param res {Object} - Express response object
  */
+
+/**
+ * @deprecated
+ * WARNING: This API endpoint is being deprecated and will be removed in future versions.
+ * Please use the updated API endpoint: `/tasks/:username` for retrieving user's task details.
+ *
+ * This API is kept temporarily for backward compatibility.
+ */
+
 const getSelfTasks = async (req, res) => {
   try {
     const { username } = req.userData;
 
-    if (username) {
-      if (req.query.completed) {
-        const allCompletedTasks = await tasks.fetchUserCompletedTasks(username);
-        return res.json(allCompletedTasks);
-      } else {
-        const allTasks = await tasks.fetchSelfTasks(username);
-        return res.json(allTasks);
-      }
+    if (!username) {
+      return res.boom.notFound("User doesn't exist");
     }
-    return res.boom.notFound("User doesn't exist");
+
+    const tasksData = req.query.completed
+      ? await tasks.fetchUserCompletedTasks(username)
+      : await tasks.fetchSelfTasks(username);
+
+    res.set(
+      "X-Deprecation-Warning",
+      "WARNING: This endpoint is deprecated and will be removed in the future. Please use /tasks/:username to get the task details."
+    );
+    return res.json(tasksData);
   } catch (err) {
     logger.error(`Error while fetching tasks: ${err}`);
     return res.boom.badImplementation(INTERNAL_SERVER_ERROR);
diff --git a/routes/tasks.js b/routes/tasks.js
index 5596f982c..99c2fca6e 100644
--- a/routes/tasks.js
+++ b/routes/tasks.js
@@ -35,6 +35,7 @@ const enableDevModeMiddleware = (req, res, next) => {
 
 router.get("/", getTasksValidator, cacheResponse({ invalidationKey: ALL_TASKS, expiry: 10 }), tasks.fetchTasks);
 router.get("/self", authenticate, tasks.getSelfTasks);
+
 router.get("/overdue", authenticate, authorizeRoles([SUPERUSER]), tasks.overdueTasks);
 router.post(
   "/",
@@ -54,6 +55,7 @@ router.patch(
 );
 router.get("/:id/details", tasks.getTask);
 router.get("/:username", tasks.getUserTasks);
+
 router.patch(
   "/self/:id",
   authenticate,
diff --git a/test/integration/tasks.test.js b/test/integration/tasks.test.js
index 74d691e4d..550618dda 100644
--- a/test/integration/tasks.test.js
+++ b/test/integration/tasks.test.js
@@ -583,6 +583,10 @@ describe("Tasks", function () {
             return done;
           }
           expect(res).to.have.status(200);
+          expect(res).to.have.header(
+            "X-Deprecation-Warning",
+            "WARNING: This endpoint is deprecated and will be removed in the future. Please use /tasks/:username to get the task details."
+          );
           expect(res.body).to.be.a("array");
           expect(res.body[0].status).to.equal(COMPLETED);
 
@@ -630,6 +634,10 @@ describe("Tasks", function () {
         .get("/tasks/self")
         .set("cookie", `${cookieName}=${authService.generateAuthToken({ userId: assignedUser })}`);
       expect(res).to.have.status(200);
+      expect(res).to.have.header(
+        "X-Deprecation-Warning",
+        "WARNING: This endpoint is deprecated and will be removed in the future. Please use /tasks/:username to get the task details."
+      );
       expect(res.body).to.be.a("array");
       expect([taskId1, taskId2]).to.include(taskId1);
     });