Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated api contract for users #126

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

updated api contract for users #126

wants to merge 2 commits into from

Conversation

iamYashSinha
Copy link

close: #125

  • The field is required because I've added a new field to the RDS document in order to fix this bug
  • See the fix here

@iamYashSinha iamYashSinha self-assigned this May 3, 2023
heyrandhir
heyrandhir suggested changes May 3, 2023
View reviewed changes
users/README.md Outdated Show resolved Hide resolved
users/README.md Outdated Show resolved Hide resolved
sahsisunny
sahsisunny reviewed May 4, 2023
View reviewed changes
Copy link
Contributor

@sahsisunny sahsisunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do migration we can also change the github_id as github_username ?

users/README.md Show resolved Hide resolved
@sahsisunny sahsisunny mentioned this pull request May 4, 2023
Open
@iamYashSinha
Copy link
Author

If we do migration we can also change the github_id as github_username ?
In the future, Yes, with the help of migration. As of now this migration method only adds github_user_id field to existing document not updating anything inside the document. Just fetching and storing the id from GitHub API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heyrandhir heyrandhir heyrandhir approved these changes

@sahsisunny sahsisunny sahsisunny approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@iamYashSinha iamYashSinha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update users API contract
3 participants
@iamYashSinha @sahsisunny @heyrandhir