Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement rate limiting on reset rate limit lambda #127

Open
RahulGoyal-tech opened this issue Nov 11, 2024 · 1 comment
Open

Implement rate limiting on reset rate limit lambda #127

RahulGoyal-tech opened this issue Nov 11, 2024 · 1 comment

Comments

@RahulGoyal-tech
Copy link

RahulGoyal-tech commented Nov 11, 2024

Issue Description

Currently lambdas operating in feature flag service has rate limit implementation using a down counter, where, count is decreased on every request to lambda. After the limit ends, access to the lambda gets restricted for all users. To reset this rate limit of any lambda, we have a separate lambda which executes a db event to update the limits. Now this reset rate limit lambda does not have a rate limit and hence becomes vulnerable to DOS and other such attacks.
To resolve this, a time based rate limiting will be implemented on this lambda which will allow it to be called only 2 times a day.

Expected Behavior

Reset Rate Limit Lambda is rate limited to 2 calls per day.

Current Behavior

Reset Rate Limit Lambda is not rate limited is vulnerable to DOS and other such attacks.

@vikhyat187
Copy link
Contributor

Hi @RahulGoyal-tech do we plan to keep this configuration of being called twice a day configurable? say if the traffic is genuiene and we want to serve, also we can think if this should be kept in a db, to avoid any deployment, and near real time updation happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants