-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Free energy is not computed for non-terminated graphs. #179
Comments
@ismailsenoz, perhaps we just want to establish theoretical grounding. The implementation will be for another milestone. |
@ismailsenoz |
We discussed with @albertpod that the heuristic of omitting entropies from the computation seems justified from theoretical grounds. Perhaps, we can discuss if further need be. |
I'm up for the discussion. However, I think #180 is orthogonal to this one and we can start those simultaneously (not necessarily you of course) |
@albertpod @bvdmitri @ismailsenoz what is the status of this? |
I'm not the right person to poke about theoretical grounds of this, but again I'm open for discussions |
We have added
predictvars
feature for the inference function. Due to some theoretical concerns, the computation of the free energy when missings are present was left aside.Now, if one wants to compute free energy on non terminated graph, he'll get
The Bethe Free Energy computation is not compatible with the prediction functionality. Set `free_energy = false` to suppress this error.
@ismailsenoz has some good insights on this one in relation to expected free energy. IMHO, we should pick it up.
The text was updated successfully, but these errors were encountered: