Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(YouTube): Disable player swipe gesture to change videos #3982

Closed
3 tasks done
LisoUseInAIKyrios opened this issue Nov 25, 2024 · 17 comments · Fixed by #4222 or #4213
Closed
3 tasks done

feat(YouTube): Disable player swipe gesture to change videos #3982

LisoUseInAIKyrios opened this issue Nov 25, 2024 · 17 comments · Fixed by #4222 or #4213
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@LisoUseInAIKyrios
Copy link
Contributor

Feature description

YouTube is experimenting with a swipe gesture for the regular (non Shorts) video player.

https://www.androidauthority.com/youtube-fullscreen-swipe-gesture-change-test-3498275/

Currently it's an a/b test turned on for some users.

Since it's client side code it should be possible to force this on/off.

 

Swipe.to.change.video.mp4

Motivation

Allow users to opt in or out of this experiment.

Acknowledgements

  • I have checked all open and closed feature requests and this is not a duplicate
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@LisoUseInAIKyrios LisoUseInAIKyrios added the Feature request Requesting a new feature that's not implemented yet label Nov 25, 2024
@LisoUseInAIKyrios

This comment has been minimized.

@Zeratoxx

This comment has been minimized.

@LisoUseInAIKyrios

This comment has been minimized.

@Zeratoxx

This comment has been minimized.

@LisoUseInAIKyrios

This comment has been minimized.

@Zeratoxx

This comment has been minimized.

@LisoUseInAIKyrios

This comment has been minimized.

@Zeratoxx

This comment has been minimized.

@LisoUseInAIKyrios

This comment has been minimized.

@Zeratoxx

This comment has been minimized.

@LisoUseInAIKyrios

This comment has been minimized.

@0xrxL
Copy link

0xrxL commented Nov 25, 2024

@LisoUseInAIKyrios Should be useful (imho) to add a cuatom flags blocklist manageable by users, like litho filtering.

In this way will be more easier for everyone to catch and report the annoying A/B tests.

@LisoUseInAIKyrios
Copy link
Contributor Author

LisoUseInAIKyrios commented Nov 25, 2024

Yeah I thought about that too, but that would still require logging or some way to show what flags are currently on.

There are still a lot of places flags are used but are not hooked by any code. And there's still more complicated bit field flags where a single int contains multiple flags by bit position, and adding any kind of UI to modify those would be very difficult.

For now it's not difficult to locally edit the hook and turn on large ranges of flags and look for changes in how the app functions.

@0xrxL
Copy link

0xrxL commented Nov 25, 2024

@LisoUseInAIKyrios Mhh...not exactly. I saw many literal invokes, and all called a same method named "s" or "t" in a same class.

During "litho obfuscation saga" I added logs on these methods, to try to find the right value, but I given up due to the large amount of values printed in less than 1 sec. 😂

P.S: The same litho obfuscation check, points to the aforementioned methods. So...maybe you can give it a chance.

@LisoUseInAIKyrios
Copy link
Contributor Author

I found the 2 litho obfuscation checks flags by using the existing hook I linked to. But there are other places that don't use those such as this

internal const val launchScreenLayoutTypeLotteFeatureFlag = 268507948L
that seems to use its own custom logic.

And yes logging the flags prints out a crazy number of log entries but that's fixed by using a map/set and only logging each flag once.

@0xrxL
Copy link

0xrxL commented Nov 25, 2024

Yeah...but are just few luckily. Until now the majority of values always invoked those 2 methods.

P.S: A new A/B flag disable one tap to quote a comment, in comments section. I created a new issue to keep track of it. 😵

@LisoUseInAIKyrios
Copy link
Contributor Author

LisoUseInAIKyrios commented Dec 26, 2024

The log previously provided must not have been complete, because this is a client side feature flag (flag 45631116L) and it does show in the logs if the feature is turned on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
3 participants