-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(YouTube): Disable player swipe gesture to change videos #3982
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@LisoUseInAIKyrios Should be useful (imho) to add a cuatom flags blocklist manageable by users, like litho filtering. In this way will be more easier for everyone to catch and report the annoying A/B tests. |
Yeah I thought about that too, but that would still require logging or some way to show what flags are currently on. There are still a lot of places flags are used but are not hooked by any code. And there's still more complicated bit field flags where a single int contains multiple flags by bit position, and adding any kind of UI to modify those would be very difficult. For now it's not difficult to locally edit the hook and turn on large ranges of flags and look for changes in how the app functions. |
@LisoUseInAIKyrios Mhh...not exactly. I saw many literal invokes, and all called a same method named "s" or "t" in a same class. During "litho obfuscation saga" I added logs on these methods, to try to find the right value, but I given up due to the large amount of values printed in less than 1 sec. 😂 P.S: The same litho obfuscation check, points to the aforementioned methods. So...maybe you can give it a chance. |
I found the 2 litho obfuscation checks flags by using the existing hook I linked to. But there are other places that don't use those such as this revanced-patches/patches/src/main/kotlin/app/revanced/patches/youtube/layout/seekbar/Fingerprints.kt Line 52 in 03fa88c
And yes logging the flags prints out a crazy number of log entries but that's fixed by using a map/set and only logging each flag once. |
Yeah...but are just few luckily. Until now the majority of values always invoked those 2 methods. P.S: A new A/B flag disable one tap to quote a comment, in comments section. I created a new issue to keep track of it. 😵 |
The log previously provided must not have been complete, because this is a client side feature flag (flag |
Feature description
YouTube is experimenting with a swipe gesture for the regular (non Shorts) video player.
https://www.androidauthority.com/youtube-fullscreen-swipe-gesture-change-test-3498275/
Currently it's an a/b test turned on for some users.
Since it's client side code it should be possible to force this on/off.
Swipe.to.change.video.mp4
Motivation
Allow users to opt in or out of this experiment.
Acknowledgements
The text was updated successfully, but these errors were encountered: