Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date, IDate, and POSIXct should be distinct classes for joins #6628

Open
MichaelChirico opened this issue Nov 27, 2024 · 0 comments
Open

Date, IDate, and POSIXct should be distinct classes for joins #6628

MichaelChirico opened this issue Nov 27, 2024 · 0 comments

Comments

@MichaelChirico
Copy link
Member

I think we should implement mergeType returning I?Date, POSIXct as separate cases. That would for example solve #3506 and could make the solution here clearer.

Originally posted by @MichaelChirico in #6603 (comment)

#6602 highlights difficulty with our current approach of ignoring column class attributes for well-known classes. We already cater for two very common classes (factor and integer64); I see no reason to treat Date, POSIXct any differently.

Solving this would also solve #3506 with more generality. We should also keep #6627 (in particular the linked "join compatibility table") in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant