-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ClojureScript and caching support #75
Comments
I'm interested, but only if it doesn't significantly uglify or complicate the codebase because I'm not that interested in ClojureScript. So, my answer is: probably, yes, please pull request it, I'll almost certainly take it. |
Ok, cool. Why don't you take a look at the fork and let me know what you think. It's not done, and has some hairy edges, but I think it's going in a good direction. It's also in dire need of many more tests, and there's fair chance it might blow up under extensive use. The big changes are in Aside from the cljs support, the benefits of pluggable requesters can be seen in this little demo that just spits the request map out to the console. This kind of architecture makes it a breeze in terms of custom caching, logging, testing, etc. It also means that hard dependencies on There is additional complexity, but it's warranted (I think) and manageable. Thoughts? |
Oh and I still have to make a requester for nodejs. |
Using cljc. Tests executed via bensu/doo. Repo file download & upload excluded cf. gh issue Raynes#75
I'm currently finishing up a half-baked fork with the codebase ported to CLJX so as to support ClojureScript. The motivation was a) to have cljs support; and b) to allow pluggable HTTP clients, which in turn allows caching to be performed at the request level so users (i.e. me) don't have don't have to wrap the whole API.
I'm considering submitting a PR but don't want to spend time tidying this up if the idea is a non-starter for you.
Thoughts?
The text was updated successfully, but these errors were encountered: