From e9d7183b1700839db9b313b65fe7f7f39a2a1ab6 Mon Sep 17 00:00:00 2001 From: Tawakalt Date: Mon, 5 Feb 2024 15:59:35 +0100 Subject: [PATCH] implement PR feedback --- rasa_sdk/cli/arguments.py | 2 +- tests/test_arguments.py | 17 +++++++++++++---- 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/rasa_sdk/cli/arguments.py b/rasa_sdk/cli/arguments.py index a3b218357..c520d72af 100644 --- a/rasa_sdk/cli/arguments.py +++ b/rasa_sdk/cli/arguments.py @@ -57,5 +57,5 @@ def add_endpoint_arguments(parser): parser.add_argument( "--endpoints", default=DEFAULT_ENDPOINTS_PATH, - help="Configuration file for tracing as a yml file.", + help="Configuration file for the assistant as a yml file.", ) diff --git a/tests/test_arguments.py b/tests/test_arguments.py index 4df2806e7..bbb111d52 100644 --- a/tests/test_arguments.py +++ b/tests/test_arguments.py @@ -1,12 +1,21 @@ import rasa_sdk.endpoint as ep +import pytest +from rasa_sdk.constants import DEFAULT_ENDPOINTS_PATH -def test_arg_parser_endpoints(): + +@pytest.mark.parametrize( + "args, expected", + [ + ([], DEFAULT_ENDPOINTS_PATH), + (["--endpoints", "a.yml"], "a.yml"), + ], +) +def test_arg_parser_endpoints(args, expected): parser = ep.create_argument_parser() - args = ["--endpoints", "endpoint.yml"] cmdline_args = parser.parse_args(args) - assert cmdline_args.endpoints == "endpoint.yml" + assert cmdline_args.endpoints == expected help_text = parser.format_help() assert "--endpoints ENDPOINTS" in help_text - assert " Configuration file for tracing as a yml file." in help_text + assert " Configuration file for the assistant as a yml file." in help_text