Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function buttonDidSelected not working #50

Open
Malenea opened this issue Mar 21, 2018 · 8 comments
Open

Function buttonDidSelected not working #50

Malenea opened this issue Mar 21, 2018 · 8 comments

Comments

@Malenea
Copy link

Malenea commented Mar 21, 2018

Is not triggering at all?

func circleMenu(_ circleMenu: CircleMenu, buttonDidSelected button: UIButton, atIndex: Int) {
        print("button did select: \(atIndex)")
    }
@0ber
Copy link
Contributor

0ber commented Mar 22, 2018

Demo project works fine
screen recording 2018-03-22 at 09 59 am

@Malenea
Copy link
Author

Malenea commented Mar 22, 2018

Ok so it might be on my side, I'll look into it and make a feedback if ever I find the why.
Wich is weird cause the willSelected works like a charm.

Thanks for your reply though.

@0ber
Copy link
Contributor

0ber commented Mar 22, 2018

maybe you forgot set delegate

button.delegate = self 

@Malenea
Copy link
Author

Malenea commented Mar 22, 2018

Nope delegate was set. Just checked.

I will investigate why and tell you as soon as I find out what I did wrong.

@ghost
Copy link

ghost commented May 31, 2018

Same issue for me

@tusharjindal353
Copy link

same issue for me

@realmtai
Copy link

See CircleMenu.swift:374

        if customNormalIconView != nil && customSelectedIconView != nil {
            DispatchQueue.main.asyncAfter(deadline: .now() + duration, execute: {
                self.delegate?.circleMenu?(self, buttonDidSelected: sender, atIndex: sender.tag)
            })
        }

Well, customNormalIconView and customSelectedIconView can't be nil. It's unclear to me. I'm using ionicons-fonts not images. I can't see the reason why I need to set any images. (7f2a3f8) It might be legacy code form wayback when the delegate methods were introduced or software engineering bureaucracy. Either way, good job Alex.k for making this project possible. Only he could just push a tiny bit further. :p

realmtai pushed a commit to realmtai/circle-menu that referenced this issue Jun 29, 2018
… using ionicons-fonts not images. I can't see the reason why I need to set any images. (7f2a3f8) It might be legacy code form wayback when the delegate methods were introduced or software engineering bureaucracy. Either way, good job Alex.k for making this project possible. Only he could just push a tiny bit further :p

See issue50 Ramotion#50
@realmtai
Copy link

realmtai commented Jul 3, 2018

🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants