Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add hover effect on the navbar options and use better fonts. #39

Closed
3 tasks done
Ayush215mb opened this issue Oct 2, 2024 · 14 comments
Closed
3 tasks done
Assignees
Labels
enhancement New feature or request gssoc-ext gssoc-extd program level2 for 25 points

Comments

@Ayush215mb
Copy link
Contributor

Describe the feature

I can add a hover effect on the navbar options, use a better font, will add some spacing so it looks more classy and the favicon is also missing so will also do that.
Please assign me this and I will do all the changes and create a PR request in a hour.

Add ScreenShots

image

Record

  • I agree to follow this project's Code of Conduct
  • I'm a gssoc-24-extd contributor
  • I want to work on this issue
@Ayush215mb Ayush215mb added the enhancement New feature or request label Oct 2, 2024
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Thank you for creating this issue! 🎉 We'll look into it as soon as possible. In the meantime, please make sure to provide all the necessary details and context. If you have any questions or additional information, feel free to add them here. Your contributions are highly appreciated! 😊

You can also check our CONTRIBUTING.md for guidelines on contributing to this project.
for more information join our discord https://discord.gg/Jh3bWQ7FRN

@RamakrushnaBiswal
Copy link
Owner

Already assigned to someone #5

@Ayush215mb
Copy link
Contributor Author

okay np with that, but if you want it to be done asap then you can tell me.
I will create a better navbar in a hour and send a PR.

@RamakrushnaBiswal
Copy link
Owner

ok if if he will not do that on time i will assign you

@RamakrushnaBiswal
Copy link
Owner

RamakrushnaBiswal commented Oct 4, 2024

@Ayush215mb assigned don't do anythin in navabr just update the fonts with better alignment

@RamakrushnaBiswal RamakrushnaBiswal added level2 for 25 points gssoc-ext gssoc-extd program labels Oct 4, 2024
@Ayush215mb
Copy link
Contributor Author

@RamakrushnaBiswal shall i add the hover effect as well?

@RamakrushnaBiswal
Copy link
Owner

RamakrushnaBiswal commented Oct 4, 2024

@RamakrushnaBiswal shall i add the hover effect as well?

where in navabr ?

change the fonts of menu page

@Ayush215mb
Copy link
Contributor Author

Ayush215mb commented Oct 4, 2024

image
Is the font to your liking??
I think the menu page already has good fonts so I would recommend not changing those.

@Ayush215mb
Copy link
Contributor Author

https://github.com/user-attachments/assets/982ed494-c4fd-4375-bdf2-66b50202f048
@RamakrushnaBiswal tell me if this is to your liking, then i will create the PR

@RamakrushnaBiswal
Copy link
Owner

ok add the hover effect but change the hovering color don't change the font

in menu page use the same font as in landing page

@Ayush215mb
Copy link
Contributor Author

@RamakrushnaBiswal which color should i add ?
according to me I tried to use best color combination, other color stands out more(in a bad way) and I'm changing the fonts of menu page.

@RamakrushnaBiswal
Copy link
Owner

ok then @Ayush215mb

RamakrushnaBiswal added a commit that referenced this issue Oct 6, 2024
feat: changes the font of navbar and added a hover effect #39
@RamakrushnaBiswal
Copy link
Owner

solved via #103

Copy link
Contributor

github-actions bot commented Oct 6, 2024

Hello @Ayush215mb! Your issue #39 has been closed. Thank you for your contribution!🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc-ext gssoc-extd program level2 for 25 points
Projects
None yet
Development

No branches or pull requests

2 participants