Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: UI improvement for Price Display in Today's Special #327

Closed
6 tasks done
vaibhav-yerkar opened this issue Oct 17, 2024 · 6 comments
Closed
6 tasks done

BUG: UI improvement for Price Display in Today's Special #327

vaibhav-yerkar opened this issue Oct 17, 2024 · 6 comments
Assignees
Labels
bug Something isn't working gssoc-ext gssoc-extd program hacktoberfest accepted hacktoberfest-accepted repo level1 for 10 points

Comments

@vaibhav-yerkar
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

What went down?

There can be UI improvement for the pricing display of the Today's Sepecial

issue:

  1. no bottom padding
  2. Original Price's text color not so subtle
  3. Original Price's text size could be smaller bringing the Current Price more in focus
image

Record

  • I agree to follow this project's Code of Conduct
  • I'm a gssoc-24-ext contributor
  • I have starred the repository
  • I want to work on this issue
  • I check the issue doesn't exist
@vaibhav-yerkar vaibhav-yerkar added the bug Something isn't working label Oct 17, 2024
Copy link
Contributor

Thank you for creating this issue! 🎉 We'll look into it as soon as possible. In the meantime, please make sure to provide all the necessary details and context. If you have any questions or additional information, feel free to add them here. Your contributions are highly appreciated! 😊

You can also check our CONTRIBUTING.md for guidelines on contributing to this project.
for more information join our discord https://discord.gg/Jh3bWQ7FRN

@RamakrushnaBiswal
Copy link
Owner

what you are going to add any example @vaibhav-yerkar

@RamakrushnaBiswal RamakrushnaBiswal added the pending if needed i will assign label Oct 18, 2024
@vaibhav-yerkar
Copy link
Contributor Author

vaibhav-yerkar commented Oct 18, 2024

@RamakrushnaBiswal These are my proposed figma designs :

image
image
image

@vaibhav-yerkar
Copy link
Contributor Author

if you find it appealing , let me know
and also mention whether you want the text alignment to be centred or the left aligned

@RamakrushnaBiswal
Copy link
Owner

@vaibhav-yerkar go for 1st design ✔️

@RamakrushnaBiswal RamakrushnaBiswal added level2 for 25 points gssoc-ext gssoc-extd program hacktoberfest accepted hacktoberfest-accepted repo and removed pending if needed i will assign labels Oct 19, 2024
@RamakrushnaBiswal RamakrushnaBiswal added level1 for 10 points and removed level2 for 25 points labels Oct 20, 2024
RamakrushnaBiswal added a commit that referenced this issue Oct 20, 2024
Fix - UI enhancemend for Menu Page - Today's Special #327
Copy link
Contributor

Hello @vaibhav-yerkar! Your issue #327 has been closed. Thank you for your contribution!🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc-ext gssoc-extd program hacktoberfest accepted hacktoberfest-accepted repo level1 for 10 points
Projects
None yet
Development

No branches or pull requests

2 participants