Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add github pre-commit hool to prevent eslint warnings #291

Open
4 tasks done
lade6501 opened this issue Oct 15, 2024 · 2 comments
Open
4 tasks done

Feat: Add github pre-commit hool to prevent eslint warnings #291

lade6501 opened this issue Oct 15, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request gssoc-ext gssoc-extd program hacktoberfest accepted hacktoberfest-accepted repo level2 for 25 points

Comments

@lade6501
Copy link
Contributor

Describe the feature

In current scenario devs are able to commit their changes even if eslint warnings are present.
By adding a pre-commit hook for eslint devs will only be able to commit there changes when all eslint warnings are addressed.
This will enhance code quality and readability of code.

Add ScreenShots

$ git commit

✔ Preparing lint-staged...
❯ Running tasks for staged files...
  ❯ packages/frontend/.lintstagedrc.json — 1 file
    ↓ *.js — no files [SKIPPED]
    ❯ *.{json,md} — 1 file
      ⠹ prettier --write
  ↓ packages/backend/.lintstagedrc.json — 2 files
    ❯ *.js — 2 files
      ⠼ eslint --fix
    ↓ *.{json,md} — no files [SKIPPED]
◼ Applying modifications from tasks...
◼ Cleaning up temporary files...

Record

  • I agree to follow this project's Code of Conduct
  • I have starred the repository
  • I'm a gssoc-24-extd contributor
  • I want to work on this issue
@lade6501 lade6501 added the enhancement New feature or request label Oct 15, 2024
Copy link
Contributor

Thank you for creating this issue! 🎉 We'll look into it as soon as possible. In the meantime, please make sure to provide all the necessary details and context. If you have any questions or additional information, feel free to add them here. Your contributions are highly appreciated! 😊

You can also check our CONTRIBUTING.md for guidelines on contributing to this project.
for more information join our discord https://discord.gg/Jh3bWQ7FRN

@RamakrushnaBiswal
Copy link
Owner

good idea @lade6501 assigned

@RamakrushnaBiswal RamakrushnaBiswal added level2 for 25 points gssoc-ext gssoc-extd program hacktoberfest accepted hacktoberfest-accepted repo labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc-ext gssoc-extd program hacktoberfest accepted hacktoberfest-accepted repo level2 for 25 points
Projects
None yet
Development

No branches or pull requests

2 participants