Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IElectricMinecart's ChargeHandler.balance method can be an issue #13

Closed
skyboy opened this issue May 2, 2016 · 1 comment
Closed

IElectricMinecart's ChargeHandler.balance method can be an issue #13

skyboy opened this issue May 2, 2016 · 1 comment

Comments

@skyboy
Copy link

skyboy commented May 2, 2016

The method mods/railcraft/api/electricity/IElectricMinecart$ChargeHandler.balance simply splits the charge of two handlers exactly evenly between them, with no regard for the capacity of the two handlers, potentially leading to a situation where a very large capacity handler and a low capacity handler are made to balance with each other, massively overflowing the smaller one.

@CovertJaguar
Copy link
Member

CovertJaguar commented May 3, 2016

This was considered in the design and determined that the cpu cycles that the checks cost wasn't worth the result. Additionally, ChargeHandler is final, so maxCapacity is always 10000.

Besides, the plan atm is to trash this code entirely and redesign the system from scratch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants