Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On the x64 / chromium branch getting damaged by an NPC creates a lua error #126

Open
wolfestridershooter opened this issue Feb 1, 2024 · 7 comments

Comments

@wolfestridershooter
Copy link

wolfestridershooter commented Feb 1, 2024

When an NPC damages the player with this addon installed on the x64 / chromium branch a lua error occurs.
Of course I made sure to disable all of my addons except Wiremod and CAP when testing this.

[cap-master] addons/cap-master/lua/entities/shield_core_buble/init.lua:341: attempt to call method 'GetClass' (a nil value)
  1. v - addons/cap-master/lua/entities/shield_core_buble/init.lua:341
   2. unknown - lua/includes/modules/hook.lua:96 (x47)

(Thanks @gabrie155 for letting me know it only occurred on the x64 / chromium branch)
@AlexALX if you see this please review #125 because it will fix this issue and improve on the shield core

@gabrie155
Copy link

@wolfestridershooter that issue is because you are on the chromium branch, i had this error myself, switch back to the normal gmod branch to see if that fixes it, if not, reinstall your game to see if that fixes it.

@wolfestridershooter
Copy link
Author

wolfestridershooter commented Feb 12, 2024

@gabrie155 Thanks for letting me know, hopefully your pull request gets merged soon

@wolfestridershooter wolfestridershooter changed the title Getting damaged by an NPC creates a lua error On the x64 branch getting damaged by an NPC creates a lua error Feb 12, 2024
@wolfestridershooter wolfestridershooter changed the title On the x64 branch getting damaged by an NPC creates a lua error On the x64 / chromium branch getting damaged by an NPC creates a lua error Feb 12, 2024
@AlexALX
Copy link
Collaborator

AlexALX commented Feb 15, 2024

@wolfestridershooter i'm right now way busy because of life problems and not only so totally unavailable in near future to review anything.

@wolfestridershooter
Copy link
Author

Understood, I hope things get better for you soon. Thank you for responding.

@gabrie155
Copy link

@AlexALX ahh hope everything works out well for you!

@wolfestridershooter yeah i think its because that ENT:GetClass doesnt exist on chromium, since its trying to find it, it cant, i will try to find something similier that will fix it entirely on chromium.

@gabrie155
Copy link

@wolfestridershooter error is fully fixed!, it will work for both the normal branch and chromium branch

@gabrie155
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants