Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor unit models #280

Open
tstorek opened this issue May 8, 2024 · 3 comments
Open

Refactor unit models #280

tstorek opened this issue May 8, 2024 · 3 comments
Assignees
Labels
feature request Request a potential feature

Comments

@tstorek
Copy link
Collaborator

tstorek commented May 8, 2024

Is your feature request related to a problem? Please describe.
Currently, filip is closely to the UNECE unit model. However, depending on the system requirements one want to add other unit standard,e.g., QUDT or BACNET.

Describe the solution you'd like

  1. Refactor the unit-model to first become also independ from pandas as proposed by Can the installation of pandas/numpy be optimized/made optional #194
  2. Integrate diffrent unit models depending on QUDT or BACnet and parse them based on their type definition, e.g. qudt:unit, bacnet:unit, unece:unit. We can make the default unit-type configurable via filip settings. I would stick to the unece as default as this is what the fiware community proposes. @SBlechmann is this correct?
  3. Prepare a way to define CustomUnits, e.g. by defining an import path using filip settings

Describe alternatives you've considered
Stay with the current

Additional context
For future work this might be kind of relevant, e.g. when integrating with frameworks as https://pint.readthedocs.io/en/stable/

Also related to #186

@tstorek tstorek added the feature request Request a potential feature label May 8, 2024
@tstorek tstorek self-assigned this May 8, 2024
Copy link

github-actions bot commented May 8, 2024

Branch 280-Refactor-unit-models created!

@tstorek
Copy link
Collaborator Author

tstorek commented May 8, 2024

@djs0109 any further suggestions?

@djs0109
Copy link
Contributor

djs0109 commented Dec 11, 2024

@tstorek Sorry for the late response. I think it's a good idea to support another unit's standards. However, I'm skeptical about integrating the unit framework pint. In my opinion, we should at most provide an example of how to use this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request a potential feature
Projects
None yet
Development

No branches or pull requests

2 participants