From f5471325f89d4fbdf83b316e9f328a8844000c6e Mon Sep 17 00:00:00 2001 From: Andrew Jameson Date: Wed, 26 Feb 2020 10:59:50 +0000 Subject: [PATCH] Renamed all references of `Trial` to `Trail`. This misspelling prevented Json.NET from setting property values. --- .../Clients/ProjectClientTests.cs | 4 ++-- Sdl.Community.GroupShareKit/Clients/IProjectClient.cs | 2 +- Sdl.Community.GroupShareKit/Clients/ProjectClient.cs | 4 ++-- Sdl.Community.GroupShareKit/Helpers/ApiUrls.cs | 2 +- .../Models/Response/{AuditTrial.cs => AuditTrail.cs} | 4 ++-- .../Response/{AuditTrialDetails.cs => AuditTrailDetails.cs} | 4 ++-- .../Models/Response/{Trial.cs => Trail.cs} | 2 +- 7 files changed, 11 insertions(+), 11 deletions(-) rename Sdl.Community.GroupShareKit/Models/Response/{AuditTrial.cs => AuditTrail.cs} (68%) rename Sdl.Community.GroupShareKit/Models/Response/{AuditTrialDetails.cs => AuditTrailDetails.cs} (67%) rename Sdl.Community.GroupShareKit/Models/Response/{Trial.cs => Trail.cs} (92%) diff --git a/Sdl.Community.GroupShareKit.Tests.Integration/Clients/ProjectClientTests.cs b/Sdl.Community.GroupShareKit.Tests.Integration/Clients/ProjectClientTests.cs index cb90f168..78328a34 100644 --- a/Sdl.Community.GroupShareKit.Tests.Integration/Clients/ProjectClientTests.cs +++ b/Sdl.Community.GroupShareKit.Tests.Integration/Clients/ProjectClientTests.cs @@ -193,10 +193,10 @@ public async Task Dashboard() } [Fact] - public async Task AuditTrial() + public async Task AuditTrail() { var groupShareClient = Helper.GsClient; - var auditTrial = await groupShareClient.Project.AuditTrial(ProjectId); + var auditTrail = await groupShareClient.Project.AuditTrail(ProjectId); Assert.True(auditTrial?.Count>0); } diff --git a/Sdl.Community.GroupShareKit/Clients/IProjectClient.cs b/Sdl.Community.GroupShareKit/Clients/IProjectClient.cs index aa17ba11..06a58949 100644 --- a/Sdl.Community.GroupShareKit/Clients/IProjectClient.cs +++ b/Sdl.Community.GroupShareKit/Clients/IProjectClient.cs @@ -758,7 +758,7 @@ public interface IProjectClient /// Thrown when the current user does not have permission to make the request. /// /// Thrown when a general API error occurs. - Task> AuditTrial(string projectId); + Task> AuditTrail(string projectId); /// /// Returns the projects report data diff --git a/Sdl.Community.GroupShareKit/Clients/ProjectClient.cs b/Sdl.Community.GroupShareKit/Clients/ProjectClient.cs index 61e1eb3c..6ac4eae6 100644 --- a/Sdl.Community.GroupShareKit/Clients/ProjectClient.cs +++ b/Sdl.Community.GroupShareKit/Clients/ProjectClient.cs @@ -1115,10 +1115,10 @@ public async Task DashboardStatistics() /// Thrown when the current user does not have permission to make the request. /// /// Thrown when a general API error occurs. - public Task> AuditTrial(string projectId) + public Task> AuditTrail(string projectId) { Ensure.ArgumentNotNullOrEmptyString(projectId, "projectid"); - return ApiConnection.GetAll(ApiUrls.AuditTrial(projectId), null); + return ApiConnection.GetAll(ApiUrls.AuditTrail(projectId), null); } #endregion diff --git a/Sdl.Community.GroupShareKit/Helpers/ApiUrls.cs b/Sdl.Community.GroupShareKit/Helpers/ApiUrls.cs index 6891303c..cbfac2d9 100644 --- a/Sdl.Community.GroupShareKit/Helpers/ApiUrls.cs +++ b/Sdl.Community.GroupShareKit/Helpers/ApiUrls.cs @@ -821,7 +821,7 @@ public static Uri DashboardStatistics() /// /// Returns the that retries the audit trail for all the language files in the given project /// - public static Uri AuditTrial(string projectId) + public static Uri AuditTrail(string projectId) { return "{0}/auditTrail/languageFiles/{1}".FormatUri(CurrentProjectServerUrl, projectId); } diff --git a/Sdl.Community.GroupShareKit/Models/Response/AuditTrial.cs b/Sdl.Community.GroupShareKit/Models/Response/AuditTrail.cs similarity index 68% rename from Sdl.Community.GroupShareKit/Models/Response/AuditTrial.cs rename to Sdl.Community.GroupShareKit/Models/Response/AuditTrail.cs index 50693b6b..5ce76408 100644 --- a/Sdl.Community.GroupShareKit/Models/Response/AuditTrial.cs +++ b/Sdl.Community.GroupShareKit/Models/Response/AuditTrail.cs @@ -2,9 +2,9 @@ namespace Sdl.Community.GroupShareKit.Models.Response { - public class AuditTrial + public class AuditTrail { public LanguageFileDetails LanguageFile { get; set; } - public List Trials { get; set; } + public List Trails { get; set; } } } diff --git a/Sdl.Community.GroupShareKit/Models/Response/AuditTrialDetails.cs b/Sdl.Community.GroupShareKit/Models/Response/AuditTrailDetails.cs similarity index 67% rename from Sdl.Community.GroupShareKit/Models/Response/AuditTrialDetails.cs rename to Sdl.Community.GroupShareKit/Models/Response/AuditTrailDetails.cs index fab84f86..656f4ef5 100644 --- a/Sdl.Community.GroupShareKit/Models/Response/AuditTrialDetails.cs +++ b/Sdl.Community.GroupShareKit/Models/Response/AuditTrailDetails.cs @@ -2,9 +2,9 @@ namespace Sdl.Community.GroupShareKit.Models.Response { - public class AuditTrialDetails + public class AuditTrailDetails { public LanguageFileDetails LanguageFile { get; set; } - public List Trials { get; set; } + public List Trails { get; set; } } } diff --git a/Sdl.Community.GroupShareKit/Models/Response/Trial.cs b/Sdl.Community.GroupShareKit/Models/Response/Trail.cs similarity index 92% rename from Sdl.Community.GroupShareKit/Models/Response/Trial.cs rename to Sdl.Community.GroupShareKit/Models/Response/Trail.cs index 0880de95..ec350e88 100644 --- a/Sdl.Community.GroupShareKit/Models/Response/Trial.cs +++ b/Sdl.Community.GroupShareKit/Models/Response/Trail.cs @@ -1,6 +1,6 @@ namespace Sdl.Community.GroupShareKit.Models.Response { - public class Trial + public class Trail { public string Action { get; set; } public string Timestamp { get; set; }