Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use system ld in hc-kernel-assemble #1430

Open
xw285cornell opened this issue Mar 19, 2020 · 1 comment
Open

Do not use system ld in hc-kernel-assemble #1430

xw285cornell opened this issue Mar 19, 2020 · 1 comment

Comments

@xw285cornell
Copy link

It seems hc-kernel-assemble is using the system ld, instead of $BINDIR/lld: https://github.com/RadeonOpenCompute/hcc/blob/44f47d857e1df2b1042a1d8f3a2e3225eee3d908/lib/hc-kernel-assemble.in#L185.

This will make it platform dependent (even if it works for the current ubuntu/centos, it doesn't work for some special systems). Can we change ld --> $BINDIR/lld?

@xw285cornell
Copy link
Author

It seems to complain that lld is a generic tool, and asks me to use the specific ones:

stderr: lld is a generic driver.
Invoke ld.lld (Unix), ld64.lld (macOS), lld-link (Windows), wasm-ld (WebAssembly) instead

I can pass by changing it to $BINDIR/ld.lld, but wondering if there is anything better (if you care about windows, etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant