Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for other modules (rotary, xentropy, layer_norm) #34

Open
bbartoldson opened this issue Jan 15, 2024 · 4 comments
Open

Support for other modules (rotary, xentropy, layer_norm) #34

bbartoldson opened this issue Jan 15, 2024 · 4 comments
Labels

Comments

@bbartoldson
Copy link

The non-flash-attention modules in this repository seem to not be installable with AMD cards. I would be happy to help address this but need some guidance.

Progress:

Errors:

  1. import rotary_emb returns ImportError: libc10.so: cannot open shared object file: No such file or directory.
  2. If you import torch then import rotary_emb, the result is ImportError: /.../x86_miniconda3/envs/flash2/lib/python3.11/site-packages/rotary_emb.cpython-311-x86_64-linux-gnu.so: undefined symbol: _Z17apply_rotary_cudaN2at6TensorES0_S0_S0_S0_S0_b.

Configuration:

  • PyTorch 2.1.2
  • ROCM 5.6
  • MI250 GPU
@dejay-vu
Copy link

dejay-vu commented Jan 23, 2024

/.../x86_miniconda3/envs/flash2/lib/python3.11/site-packages/rotary_emb.cpython-311-x86_64-linux-gnu.so: undefined symbol: _Z17apply_rotary_cudaN2at6TensorES0_S0_S0_S0_S0_b

It looks like there are some CUDA operators in the rotary lib which is not working on AMD GPUs. Therefore you cannot use it directly without kernel supports even if you can build it.

@ehartford
Copy link

ehartford commented Apr 8, 2024

@howiejayz hello I need rotary on amd, is this cuda operator still missing? can you please specify which ones? can i get the fix prioritized?

@dejay-vu
Copy link

dejay-vu commented Apr 8, 2024

@ehartford Could you try this PR, which has the rotary module enabled for ROCm?

@ehartford
Copy link

Thanks, I will give it a try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants