-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support time zone information in the createDate attribute in the index #67
base: develop
Are you sure you want to change the base?
Conversation
zone from the offset between createDate and gpsDateTime, if the latter is set
gpsDateTime is not available
While working on this, it reveals a challenge: if we determine the time zone for each image individually, based on the exif metadata, it may happen that some images, e.g. index items, end up having a time zone set and some don't. But we need to compare the creates date between the items in the index and the There are essentially two options to deal with this:
It is not clear, how the second option could be done. We will implement the first option. But this requires a larger change than anticipated: we need to manage attributes of the index. We need to store in the index, whether the create dates are meant to be aware or naive and we need to store a default time zone as fallback in the index. And we need to store these attributes, e.g. we need to change the index file format, see #68. |
it around in method attributes
as a dict ahead of time
'photoidx update' subcommands
to write into the file
twice, once with an offset-naive and once with an offset-aware index
- IdxFilter takes the index as additional argument, - the timeZone attribute of the index is used in the date filter, - the filter() method does not take the index argument any more.
Add time zone information in the
createDate
when creating the index. The time zone is derived from the offset between thecreateDate
andgpsDateTime
as recorded in the exif data, ifgpsDateTime
is available. As a fall back, the local time zone is assumed.Still to do:
TimeZone
attribute: if the attributes isNone
, allcreateDate
values should be naive, if the attribute is set to a time zone offset, allcreateDate
values should be aware, the time zone offset is taken as fallback if the time zone for an item cannot otherwise be determined.photo-idx create
command to set theTimeZone
attribute of the index, the default should be the local time zone.Close #7.