feat(HMS-2496): add no permission empty state #322
Conversation
| @@ -58,11 +59,14 @@ const ProvisioningWizard = ({ onClose, image, ...props }) => { | |||
| setLaunchSuccess, | |||
| }); | |||
|
|
|||
| const onNext = ({ id, name }, { prevId, prevName }) => { | |||
| console.debug(`current id: ${id}, current name: ${name}, previous id: ${prevId}, previous name: ${prevName}`); | |||
There was a problem hiding this comment.
some old debug to clean...
|
/cc @MariSvirik |
|
So permission problem is resolved, I understand from Slack. Great. Linter issue. |
amirfefer
force-pushed
the
2496
branch
2 times, most recently
from
c1d1abb
to
e8e88a1
Compare
|
IB PR has been merged |
|
LGTM, but I guess we'll need to update the IQE tests, right @mayurilahane, @akhil-jha ? :) |
yeah think we need to do some modal definition updates for this UI. |
|
/retest Huh? Not a new modal, more like a new step in current modal for users without perms |
|
It's not a new modal (the modal is created on the IB side), though the new addition in IB osbuild/image-builder-frontend#1343 adds a mandatory |
|
/retest |
1 similar comment
|
/retest |
|
As we do not have any RBAC UI test cases right now it will be safe to merge this. |
There was a problem hiding this comment.
We do not test RBAC in UI yet (luckily, as we should test this screen).
Thanks @amirfefer nice work! 👍
|
And thanks @mayurilahane for confirmation! 🎉 |
Depends on osbuild/image-builder-frontend#1343