Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recipient fails to accept a transfer spending a blank allocation #195

Closed
nicbus opened this issue Apr 18, 2024 · 5 comments · Fixed by #193
Closed

recipient fails to accept a transfer spending a blank allocation #195

nicbus opened this issue Apr 18, 2024 · 5 comments · Fixed by #193
Assignees
Labels
bug Something isn't working
Milestone

Comments

@nicbus
Copy link
Contributor

nicbus commented Apr 18, 2024

Using commit f9813b7 plus a cargo update to include rgb-std #193 I face an issue.

This is what I'm doing (wallet 1 is the issuer/sender, wallet 2 is the recipient):

  • issue a NIA asset on wallet 1
  • issue a CFA asset on wallet 1
  • send some NIA assets from wallet 1 to wallet 2
  • send some CFA assets (spending blank allocation) from wallet 1 to wallet 2

The 2nd transfer fails when the recipient tries to accept it with the following error:

Error: anchors for the same witness do not match each other.
@dr-orlovsky dr-orlovsky self-assigned this Apr 18, 2024
@dr-orlovsky dr-orlovsky added the bug Something isn't working label Apr 18, 2024
@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Apr 18, 2024
@dr-orlovsky dr-orlovsky transferred this issue from RGB-WG/rgb Apr 18, 2024
@dr-orlovsky
Copy link
Member

I need the second consignment and the data directories from both sender and receiver

@dr-orlovsky
Copy link
Member

Ok, I found a problem, here the data are not needed. The problem is related to comparison code for two anchors when they provide different proofs for different contracts

@dr-orlovsky
Copy link
Member

The solution is three-part one (all are v0.11 branches, so just do cargo update). Basically, instead of comparing anchors I had to do a dedicated operation which takes into an account that equivalent anchors may still have different parts concealed.

@dr-orlovsky dr-orlovsky linked a pull request Apr 18, 2024 that will close this issue
@dr-orlovsky dr-orlovsky moved this to In review in RGB release v0.11 Apr 19, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in RGB release v0.11 Apr 19, 2024
@dr-orlovsky
Copy link
Member

Sorry, I mistakenly merged PR and it closed this issue. Feel free to re-open it if the PR hasn't fixed it.

@nicbus
Copy link
Contributor Author

nicbus commented Apr 19, 2024

Re-tested after a cargo update and transfer accept is now successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants