[ Bug ] Gold / XP Leaderboards don't work in custom games

[sdomi4]

Original Issue: RCVolus/league-observer-tool#28

Describe the bug
When using this tool with prod-toolkit the Gold and Level leaderboard works when spectating a Ranked Game. When spectating a custom game both of those are blank.

System:

OS: Windows
Version: 6.7.2 (or whatever the latest which we had to manually install is)

[Himyu]

We added some changes to the code of the ingame module to fix this and some other issues

[FireFoXz09]

Gold and XP seem to work now in custom games (as they show something), but the XP + Level seems off, as some player don't have the right level displayed sometimes (off by 1 level). Maybe related to all the changes with the Riot ID or something else (again)

[Himyu]

Probably related to #552 as well

[Himyu]

As mentioned in #522 there was an issue with the tool trying to save - player levels multiple times which also caused this issue and should also be fixed with the newest patch to the in-game module.

[JustSxm]

I will confirm this in my next cast which might be after christmas

[FireFoXz09]

Tested it today in custom games and it was buggy, giving wrong levels for players (some were at lvl "0" with 0 XP)

[chinzchi]

I found that if I don't select Level Display, it won't show that level on the leader board and it will display incorrectly.
For example, I set the Level Display to be 6, 11, 16 every time they have an ultimate skill. If they're not at those levels, It will be 0 early in the game.

[Himyu]

I found that if I don't select Level Display, it won't show that level on the leader board and it will display incorrectly.
For example, I set the Level Display to be 6, 11, and 16 every time they have an ultimate skill. If they're not at those levels, It will be 0 early in the game.

Based on that comment, I know what the problem is and can supply a fix for that later today.

[Himyu]

We added a patch that should fix this issue 👍

[chinzchi]

We added a patch that should fix this issue 👍

How can I update it without affecting the CSS file I previously edited?

[sdomi4]

If you edited the CSS directly in the module, you will need to back up your changes and reapply them. Ideally, you apply CSS changes through a theme which will not be affected by updates.

[chinzchi]

Gold Leader Board in Custom game (Tournament Draft) Displayed incorrect. It's like pulling in old gameplay data of players in the custom room to display. It's based on someone playing Renekton while playing Thresh in room.
https://youtu.be/xLxaUaM1zRg?t=10831 on time 3:00:33

[sdomi4]

This is probably due to champions being carried over from the previous game being spectated. Resetting the game state (ideally before/at the start of the game) should fix this, but adding better automatic resets once a game ends is something we'll look into.

[chinzchi]

This is probably due to champions being carried over from the previous game being spectated. Resetting the game state (ideally before/at the start of the game) should fix this, but adding better automatic resets once a game ends is something we'll look into.

Do I have to press this button? Is it necessary?

[chinzchi]

Reset Game State
Only use this when really needed, all game data of the current game will be lost!

Furthermore, what effect will it have?

[FireFoXz09]

Reset Game State Only use this when really needed, all game data of the current game will be lost!

Furthermore, what effect will it have?

If you press it DURING a game, some data won't be synced, like the number of turrets destroyed, for example. By pressing it before or at the beginning, you don't miss any major events so all stats resets acordingly.