From 0e6ba955e5f7ded915de4fe60ae6367fd1852562 Mon Sep 17 00:00:00 2001
From: R-Sourabh <rsourabh002@gmail.com>
Date: Wed, 13 Nov 2024 14:53:55 +0530
Subject: [PATCH] Improved: added support to show DataManagerLogs for mobile
 view(#680)

---
 src/views/DataManagerLogDetails.vue | 4 ++--
 src/views/JobDetails.vue            | 6 +++++-
 src/views/Pipeline.vue              | 2 +-
 3 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/src/views/DataManagerLogDetails.vue b/src/views/DataManagerLogDetails.vue
index d13fbea7..5d80031d 100644
--- a/src/views/DataManagerLogDetails.vue
+++ b/src/views/DataManagerLogDetails.vue
@@ -83,12 +83,12 @@
           </ion-item>
   
           <ion-label>
-            {{ getDateTime(log.startDateTime) }}
+            {{ log.startDateTime ? getDateTime(log.startDateTime) : '-' }}
             <p>{{ translate('Started') }}</p>
           </ion-label>
   
           <ion-label>
-            {{ getDateTime(log.finishDateTime) }}
+            {{ log.finishDateTime ? getDateTime(log.finishDateTime) : '-' }}
             <p>{{ translate('Finished') }}</p>
           </ion-label>
 
diff --git a/src/views/JobDetails.vue b/src/views/JobDetails.vue
index 4266336b..ebe0fac9 100644
--- a/src/views/JobDetails.vue
+++ b/src/views/JobDetails.vue
@@ -9,7 +9,7 @@
 
     <ion-content>
       <InitialJobConfiguration v-if="jobCategory === 'initial-load'" :type='type' :shopifyOrderId='lastShopifyOrderId' :key="currentJob" />
-      <JobConfiguration v-else :status="currentJob?.status === 'SERVICE_DRAFT' ? currentJob?.status : currentJob?.tempExprId" :type="freqType" :key="currentJob"/>
+      <JobConfiguration v-else :status="currentJob?.status === 'SERVICE_DRAFT' ? currentJob?.status : currentJob?.tempExprId" :type="freqType" :key="currentJob" :historyJobConfig="checkJobStatus(currentJob?.statusId)"/>
     </ion-content>
   </ion-page>
 </template>
@@ -87,6 +87,10 @@ export default defineComponent({
         const jobFreqTypeId = (Object.keys(this.jobFrequencyType).find((enumId: any) => enumId === id)) as any;
         this.freqType = (id && jobFreqTypeId) && this.jobFrequencyType[jobFreqTypeId];
       }
+    },
+    checkJobStatus(statusId: string) {
+      const statuses = ["SERVICE_CANCELLED", "SERVICE_CRASHED", "SERVICE_FAILED", "SERVICE_FINISHED", "SERVICE_RUNNING", "SERVICE_QUEUED"];
+      return statuses.includes(statusId);
     }
   },
   mounted() {
diff --git a/src/views/Pipeline.vue b/src/views/Pipeline.vue
index fa9f8f55..de90cbc7 100644
--- a/src/views/Pipeline.vue
+++ b/src/views/Pipeline.vue
@@ -608,7 +608,7 @@ export default defineComponent({
       this.freqType = appFreqType ? appFreqType[1] : "default"
 
       await this.store.dispatch('job/updateCurrentJob', { job });
-      if (!this.isDesktop && this.segmentSelected === 'history' && job.runtimeData?.configId) {
+      if(this.segmentSelected === 'history' && job.runtimeData?.configId) {
         await this.store.dispatch('job/fetchDataManagerLogs', job.jobId)
       }
       if(!this.isDesktop && job?.jobId) {