From 2811c1320b1f5a2fb3569f3a5be7fe3a89946d2d Mon Sep 17 00:00:00 2001
From: Mohammad Zubair Ali <zubair@expresstech.io>
Date: Wed, 19 Jun 2024 15:02:44 +0530
Subject: [PATCH] fixed php warning if quiz_settings are blank

---
 php/classes/class-qsm-contact-manager.php | 4 ++--
 php/classes/class-qsm-install.php         | 4 +++-
 php/classes/class-qsm-migrate.php         | 3 ++-
 3 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/php/classes/class-qsm-contact-manager.php b/php/classes/class-qsm-contact-manager.php
index 70e7ba61d..1b89791f1 100644
--- a/php/classes/class-qsm-contact-manager.php
+++ b/php/classes/class-qsm-contact-manager.php
@@ -569,7 +569,7 @@ public static function generate_contact_field( $field, $index, $quiz_options, $d
 				/**
 				 * Add options validation
 				 */
-				if ( isset( $field['options'] ) && !empty( trim( $field['options'] ) ) ) {
+				if ( isset( $field['options'] ) && ! empty( trim( $field['options'] ) ) ) {
 				?>
 				<span class='mlw_qmn_question qsm_question'><?php echo esc_attr( $field_label ); ?></span>
 				<div class='qmn_radio_answers <?php echo esc_attr( $class ); ?>'>
@@ -603,7 +603,7 @@ class="qmn_quiz_radio"
 					$fieldAttr .= " autocomplete='off' ";
 				}
 				// If REQUIRED is set then assigning the required class
-				if ( isset( $field['options'] ) && !empty( trim( $field['options'] ) ) ) {
+				if ( isset( $field['options'] ) && ! empty( trim( $field['options'] ) ) ) {
 				?>
 				<span class='mlw_qmn_question qsm_question'><label for="contact_field_<?php echo esc_attr( $index ) ?>"><?php echo esc_attr( $field_label ); ?></label></span>
 				<select class='<?php echo esc_attr( $class ); ?>' name='contact_field_<?php echo esc_attr( $index ); ?>' id='contact_field_<?php echo esc_attr( $index ); ?>'>
diff --git a/php/classes/class-qsm-install.php b/php/classes/class-qsm-install.php
index 322ad7bef..7ee73ac20 100644
--- a/php/classes/class-qsm-install.php
+++ b/php/classes/class-qsm-install.php
@@ -2029,7 +2029,9 @@ public function update() {
 			if ( ! get_option( 'fixed_duplicate_questions' ) ) {
 				QSM_Migrate::fix_duplicate_questions();
 			}
-			QSM_Migrate::fix_deleted_quiz_posts();
+			if ( ! get_option( 'fix_deleted_quiz_posts' ) ) {
+				QSM_Migrate::fix_deleted_quiz_posts();
+			}
 
 			update_option( 'mlw_quiz_master_version', $data );
 		}
diff --git a/php/classes/class-qsm-migrate.php b/php/classes/class-qsm-migrate.php
index 98db81c63..ca763c4db 100644
--- a/php/classes/class-qsm-migrate.php
+++ b/php/classes/class-qsm-migrate.php
@@ -123,7 +123,7 @@ public static function fix_duplicate_questions() {
 		if ( ! empty( $all_quizzes ) ) {
 			foreach ( $all_quizzes as $quiz ) {
 				$quiz_id     = $quiz->quiz_id;
-				$settings    = maybe_unserialize( $quiz->quiz_settings );
+				$settings    = ! empty( $quiz->quiz_settings ) ? maybe_unserialize( $quiz->quiz_settings ) : array();
 				$pages       = isset( $settings['pages'] ) ? maybe_unserialize( $settings['pages'] ) : array();
 				$qpages      = isset( $settings['qpages'] ) ? maybe_unserialize( $settings['qpages'] ) : array();
 				if ( ! empty( $pages ) ) {
@@ -179,6 +179,7 @@ public static function fix_deleted_quiz_posts() {
 				}
 			}
 		}
+		update_option( 'fix_deleted_quiz_posts', 1 );
 	}
 
 }