Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoomify and Controlify mods cannot start together because of a Quilted Fabric API quirk #425

Closed
NyaomiDEV opened this issue Apr 23, 2024 · 5 comments
Labels
bug something isn't working

Comments

@NyaomiDEV
Copy link

NyaomiDEV commented Apr 23, 2024

Relevant issue at the other end: isXander/Zoomify#195

It seems as though the version parse method used by Quilt is ever so slightly different to induce some mods' code into behaving erratically.

Relevant calls:
https://github.com/isXander/Zoomify/blob/1.20/src/main/kotlin/dev/isxander/zoomify/integrations/IntegrationHelper.kt

@isXander
Copy link

QFAPI has nothing to do with this.
This is an issue with Quilt Loader itself.

@OroArmor OroArmor transferred this issue from QuiltMC/quilted-fabric-api Apr 23, 2024
@OroArmor
Copy link
Member

Thanks for reminding me to transfer the issue

@NyaomiDEV
Copy link
Author

QFAPI has nothing to do with this. This is an issue with Quilt Loader itself.

@isXander Sorry, I tried! Sorry to you too @OroArmor :(

@isXander
Copy link

I'd assume that 2.x.x in Quilt does not match betas.

AlexIIL added a commit that referenced this issue Apr 23, 2024
…cate. (#425)

This used to turn "2.x" or "=2.x" into "^2-", however a while ago this accidently got changed to "^2".

Honestly, I'm unsure which way is correct. However this was changed accidently during our Version.Sementic switching to non-null build & pre-release, so it's been changed back.
@isXander
Copy link

Can be closed?

steviegt6 referenced this issue in steviegt6/fable Jul 2, 2024
* Add missing changelog entry.

* Bump for 0.25.0 release.

* Publish dependencies as seperate module (#418)

* Dependency publishing and use toolchains

* Fix up tests and exclude specific included dependencies

* Add foojay for toolchains to work

* Add a system property to disable DelegatingUrlStreamHandlerFactory. (#424)

* Fix "2.x" not appending an empty build version to the resulting predicate. (#425)

This used to turn "2.x" or "=2.x" into "^2-", however a while ago this accidently got changed to "^2".

Honestly, I'm unsure which way is correct. However this was changed accidently during our Version.Sementic switching to non-null build & pre-release, so it's been changed back.

* Add missing license

* Change indentation in McVersionLookup to match upstream

* 24w14potato support

forked from 24w12a

* 24w14potato support (part 2)

* Update Mixin (#919)

* Update Mixin

* Update Mixin

* 0.26.0 changelog, and bump for beta release 0.26.0-beta.1

* bump qconf (#423)

* Update changelog

* Link

* Fix Fabric mod author and contributor being duplicated (#427)

* Fix mod contributors being reordered when read (#426)

* Fix regression which moved the global cache to the wrong location (#429)

* Bump version

* Allowed the GameProvider to provide the namespace (#428)

* Allowed the GameProvider to provide the namespace

* Removed the deprivation warning on the MappingConfiguration

* Removed process functions where the namespace isn't provided from being deprecated in the GamePatch

* Fixup of commit f71eda1a with AlexIIL's suggestions

* Allowed for no namespace to be provided when locating entrypoints

* Release beta

* Fix knot class loading allowlist not working (#430)

* Bump version

* Add a system property to disable unsupported mod warnings (#434)

The system property is `loader.ignore_unsupported_mods` - set this to true with `-Dloader.ignore_unsupported_mods=true` to ignore all unsupported mods.

This is a straightforward solution to #433.

* Two changes to dates in the report generator:

- Include the zone offset (raw time number like +0100) in the actual crash report file. This should help when assisting people in other timezones - as we can figure out if a crash report was generated just now, or is an older one.
- Change from CLOCK_HOUR_OF_DAY to HOUR_OF_DAY. This means we'll get digital time at 15 minutes past midnight (00:15) rather than analog time (24:15)

* Added support for 1.21

* Provide fabric loader 0.15.11

* Bump for beta. (Just before releasing a proper stable -_- )

* Update changelog

* Bump for 0.26.0 release!

* Fixed crash reports being printed to system out, rather than the log. (This is a problem for launchers which don't replay sysout, like Modrinth)

* Fixed the gui system closing the whole game if the forked gui process encountered an error, rather than returning the error to the original process.

* Two bug fixes:

1: Implement additional reflections patch system for shaded versions of the reflections library.

Currently this only targets the one used by kubejs-offline.
(TODO) Add system property support for additional packages.

2: Fix gui icons being sent too early, causing crashes in the gui server.

Also added a new system property to print all gui packets.

* Add missing license headers.

* Change plugin classes to be made available after plugins have been loaded.

* Delete.

* Update licenses.

---------

Co-authored-by: AlexIIL <[email protected]>
Co-authored-by: Luke Bemish <[email protected]>
Co-authored-by: modmuss50 <[email protected]>
Co-authored-by: ix0rai <[email protected]>
Co-authored-by: Lilly Rose Berner <[email protected]>
Co-authored-by: glitch <[email protected]>
Co-authored-by: coolGi <[email protected]>
Co-authored-by: Vasiliy <[email protected]>
Co-authored-by: WinPlay02 <[email protected]>
@ix0rai ix0rai closed this as completed Aug 24, 2024
@ix0rai ix0rai added the bug something isn't working label Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants