Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value of loop count in Correlation Detector Function #19

Open
MichKe95 opened this issue Oct 9, 2019 · 2 comments
Open

Value of loop count in Correlation Detector Function #19

MichKe95 opened this issue Oct 9, 2019 · 2 comments
Assignees

Comments

@MichKe95
Copy link

MichKe95 commented Oct 9, 2019

The value for loop_cnt (set to awgs_0_userregs_0) in the prepare function for the UHFQC_correlation_detector is set to nr_averages*nr_sweep_points. This seems odd, as loop_cnt should be the number of averages the UHFQC should loop through.

Questions:

  • Are we using this detector function?
  • Is the value for loop_cnt correct?
@stephlazar
Copy link

Yes we are using this detector.
The loop_cnt is wrong. It should be the same as it is in the UHFQC_integrated_average_detector.
The correlation detector has not been used with the new wfm generation framework. I believe in the old framework (where we were not uploading several RO pulse segments, but just one), this was of setting loop_cnt was needed.

@nathlacroix
Copy link

@stephlazar @MichKe95 has this been fixed somewhere/ is now outdated?
If it has been fixed, please point to the relevant commit and if it is no longer relevant, we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants