Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphviz.py: add missing comma in IMAGE_TYPES #1339

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

larsesser
Copy link
Contributor

Hi there, I just stumbled over this and wanted to propose a quick fix, by adding the missing comma. This prevented the usage of "vmlz" and "vrml" image type.

this prevented the usage of "vmlz" and "vrml" image type
@CLAassistant
Copy link

CLAassistant commented Dec 14, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@IvanIsCoding IvanIsCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! I am shocked the linter did not find this issue. We clearly overlooked it during a refactor most likely

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12330003763

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.868%

Totals Coverage Status
Change from base Build 12281511833: 0.0%
Covered Lines: 18284
Relevant Lines: 19072

💛 - Coveralls

@IvanIsCoding IvanIsCoding added this pull request to the merge queue Dec 14, 2024
Merged via the queue into Qiskit:main with commit 25077aa Dec 14, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants