This repository has been archived by the owner on May 17, 2024. It is now read-only.
fix(advocates): display whole country name in advocate cards #3535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackoconnordev
requested review from
techtolentino,
eddybrando and
y4izus
as code owners
|
In I don't believe this is related to anything I've done so not sure if people think that particular step succeeding should be mandatory for a small PR like this (if the proposed change is acceptable of course). 
|
HuangJunye
reviewed
Sep 28, 2023
There was a problem hiding this comment.
Thanks a lot for your contribution. I am not a maintainer of this repo nor am I familiar with JavaScript 😅. I can see that the issues were potentially introduced in #3108. @eddybrando can you please have a look in this PR? It's important to fix this issue for the advocate page. Thank you.
A bad type led to the first letter of a string being indexed instead of the first string in an array of length one.
eddybrando
force-pushed
the
3526-include-more-than-first-letter-of-country-name
branch
from
9d12cf1 to
dbce3d1
Compare
eddybrando
approved these changes
Jan 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Country names now display in full. A bad type led to the first letter of a string being unintentionally indexed instead of the first string in an array of length one.
Fixes #3526
Implementation details
advocate.country's type wasstring[]. I imagine someone in the past saw this and assumed because country is a singular noun that it was a string array of length one, and added the [0] to the end of theadvocate.countryprop.This removes the unnecessary indexing from
advocate.countrywhich was only selecting the first letter and updates the types that led to the confusion.How to read this PR
Start with if
advocate.countryshould be astringorstring[]type. Change to the component props follows.Screenshots
Dev advocates page with the fix.