-
Notifications
You must be signed in to change notification settings - Fork 108
[EventCard] limit description lengths #3206
Comments
@techtolentino is it looking good? |
Thank you for exploring this @tarunsamanta2k20. We're going to need to figure out how we'll address this... it might not be a CSS change, and it could be an effort of ensuring our descriptions have limits, in the DB... We'll come back to update this ticket once we come up w/ a consensus. |
The EventCard component takes the description from the given. That means it could possible receive something different from text. I like the idea of truncating the description within the component since the description limit is something unique to the EventCard component but because it can receive anything besides just text, it shouldn’t. I propose to change the component so that the description is another property instead of a child component but this could only be done if we never want content other than text. |
Signed-off-by: Pablo Aragón <[email protected]>
Signed-off-by: Pablo Aragón <[email protected]>
Signed-off-by: Pablo Aragón <[email protected]>
…ion to the top Signed-off-by: Pablo Aragón <[email protected]>
Signed-off-by: Pablo Aragón <[email protected]>
Signed-off-by: Pablo Aragón <[email protected]>
Signed-off-by: Pablo Aragón <[email protected]>
Signed-off-by: Pablo Aragón <[email protected]>
…ion to the top Signed-off-by: Pablo Aragón <[email protected]>
Signed-off-by: Pablo Aragón <[email protected]>
Signed-off-by: Pablo Aragón <[email protected]>
Signed-off-by: Pablo Aragón <[email protected]>
Signed-off-by: Pablo Aragón <[email protected]>
…ion to the top Signed-off-by: Pablo Aragón <[email protected]>
Signed-off-by: Pablo Aragón <[email protected]>
Signed-off-by: Pablo Aragón <[email protected]>
Signed-off-by: Pablo Aragón <[email protected]>
Signed-off-by: Pablo Aragón <[email protected]>
…ion to the top Signed-off-by: Pablo Aragón <[email protected]>
Signed-off-by: Pablo Aragón <[email protected]>
Signed-off-by: Pablo Aragón <[email protected]>
* feat(#3206): change mock data Signed-off-by: Pablo Aragón <[email protected]> * feat(#3206): truncate EventsCard description Signed-off-by: Pablo Aragón <[email protected]> * feat(#3206): UICard content sticked to the bottom, EventsCar description to the top Signed-off-by: Pablo Aragón <[email protected]> * feat(#3206): toggle description into UiCard Signed-off-by: Pablo Aragón <[email protected]> * fix(#3206): refactor description limited by char length Signed-off-by: Pablo Aragón <[email protected]> * fix: card ctas inline * fix(ui-card): remove extra spacing after header * chore: remove unnecessary line --------- Signed-off-by: Pablo Aragón <[email protected]> Co-authored-by: Eddybrando Vásquez <[email protected]>
Feature description
Currently, we allow cards to have a description by rendering content given in the
<slot>
outlet.However, sometimes the content can become really long; this not only throws off the layout from other cards, but it creates inconsistency.
We should figure out a way to limit the description passed into the event cards, either by limiting the content in the data, or figuring out some method of truncation.
Screenshot
Card content guidelines
Figma board
Additional context
This issue might occur on other card implementations as well, but it's most evident in event cards.
The text was updated successfully, but these errors were encountered: