Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

[EventCard] limit description lengths #3206

Closed
techtolentino opened this issue May 11, 2023 · 3 comments · Fixed by #3484
Closed

[EventCard] limit description lengths #3206

techtolentino opened this issue May 11, 2023 · 3 comments · Fixed by #3484
Assignees
Labels
feature New features and enhancements.

Comments

@techtolentino
Copy link
Contributor

techtolentino commented May 11, 2023

Feature description

Currently, we allow cards to have a description by rendering content given in the <slot> outlet.

However, sometimes the content can become really long; this not only throws off the layout from other cards, but it creates inconsistency.

We should figure out a way to limit the description passed into the event cards, either by limiting the content in the data, or figuring out some method of truncation.

Screenshot

Screenshot 2023-05-11 at 12 53 50 PM (2)

Card content guidelines

Figma board

Additional context

This issue might occur on other card implementations as well, but it's most evident in event cards.

@techtolentino techtolentino added the feature New features and enhancements. label May 11, 2023
@SamantaTarun
Copy link
Contributor

@techtolentino is it looking good?

image

@techtolentino
Copy link
Contributor Author

Thank you for exploring this @tarunsamanta2k20.

We're going to need to figure out how we'll address this... it might not be a CSS change, and it could be an effort of ensuring our descriptions have limits, in the DB...

We'll come back to update this ticket once we come up w/ a consensus.

@y4izus y4izus added this to Qiskit.org Aug 1, 2023
@y4izus y4izus moved this to 🔖 To do in Qiskit.org Aug 1, 2023
@paaragon
Copy link
Contributor

paaragon commented Aug 2, 2023

The EventCard component takes the description from the given. That means it could possible receive something different from text.

I like the idea of truncating the description within the component since the description limit is something unique to the EventCard component but because it can receive anything besides just text, it shouldn’t.

I propose to change the component so that the description is another property instead of a child component but this could only be done if we never want content other than text.

@paaragon paaragon moved this from 🔖 To do to 🏗 In progress in Qiskit.org Aug 3, 2023
paaragon added a commit that referenced this issue Aug 3, 2023
Signed-off-by: Pablo Aragón <[email protected]>
paaragon added a commit that referenced this issue Aug 3, 2023
@paaragon paaragon linked a pull request Aug 3, 2023 that will close this issue
paaragon added a commit that referenced this issue Aug 3, 2023
Signed-off-by: Pablo Aragón <[email protected]>
paaragon added a commit that referenced this issue Aug 3, 2023
paaragon added a commit that referenced this issue Aug 7, 2023
paaragon added a commit that referenced this issue Aug 7, 2023
@techtolentino techtolentino moved this from 🏗 In progress to 👀 In review in Qiskit.org Aug 8, 2023
paaragon added a commit that referenced this issue Aug 9, 2023
eddybrando pushed a commit that referenced this issue Jan 15, 2024
eddybrando pushed a commit that referenced this issue Jan 15, 2024
eddybrando pushed a commit that referenced this issue Jan 15, 2024
eddybrando pushed a commit that referenced this issue Jan 15, 2024
eddybrando pushed a commit that referenced this issue Jan 15, 2024
y4izus pushed a commit that referenced this issue Jan 15, 2024
y4izus pushed a commit that referenced this issue Jan 15, 2024
y4izus pushed a commit that referenced this issue Jan 15, 2024
y4izus pushed a commit that referenced this issue Jan 15, 2024
y4izus pushed a commit that referenced this issue Jan 15, 2024
eddybrando pushed a commit that referenced this issue Jan 16, 2024
eddybrando pushed a commit that referenced this issue Jan 16, 2024
eddybrando pushed a commit that referenced this issue Jan 16, 2024
eddybrando pushed a commit that referenced this issue Jan 16, 2024
eddybrando pushed a commit that referenced this issue Jan 16, 2024
eddybrando added a commit that referenced this issue Jan 17, 2024
* feat(#3206): change mock data

Signed-off-by: Pablo Aragón <[email protected]>

* feat(#3206): truncate EventsCard description

Signed-off-by: Pablo Aragón <[email protected]>

* feat(#3206): UICard content sticked to the bottom, EventsCar description to the top

Signed-off-by: Pablo Aragón <[email protected]>

* feat(#3206): toggle description into UiCard

Signed-off-by: Pablo Aragón <[email protected]>

* fix(#3206): refactor description limited by char length

Signed-off-by: Pablo Aragón <[email protected]>

* fix: card ctas inline

* fix(ui-card): remove extra spacing after header

* chore: remove unnecessary line

---------

Signed-off-by: Pablo Aragón <[email protected]>
Co-authored-by: Eddybrando Vásquez <[email protected]>
@y4izus y4izus moved this from 👀 In review to ✅ Done in Qiskit.org Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New features and enhancements.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants