fix(advocates): display whole country name in advocate cards (#3535)

* fix(advocates): display whole country name in advocate cards A bad type led to the first letter of a string being indexed instead of the first string in an array of length one. * test(advocates): update country property type --------- Co-authored-by: Eddybrando Vásquez <[email protected]>
Qiskit · Jan 12, 2024 · cbe78bd · cbe78bd
1 parent 8b365e5
commit cbe78bd
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/components/Advocates/MeetTheAdvocates/AdvocatesMeetTheAdvocates.vue b/components/Advocates/MeetTheAdvocates/AdvocatesMeetTheAdvocates.vue
@@ -58,7 +58,7 @@
               :name="advocate.name"
               :image="advocate.image"
               :city="advocate.city"
-              :country="advocate.country[0]"
+              :country="advocate.country"
               :region="advocate.region"
               :slack-id="advocate.slackId"
               :slack-username="advocate.slackUsername"

diff --git a/hooks/advocate-conversion-utils.ts b/hooks/advocate-conversion-utils.ts
@@ -95,7 +95,7 @@ class AdvocatesAirtableRecords extends AirtableRecords {
     return record.get(this.recordFields!.city);
   }
 
-  public getCountry(record: any): string[] {
+  public getCountry(record: any): string {
     return record.get(this.recordFields!.country);
   }
 

diff --git a/tests/hooks/utils/conversion-utils.spec.ts b/tests/hooks/utils/conversion-utils.spec.ts
@@ -22,7 +22,7 @@ describe("writeJSONToFile", () => {
         image: "/images/advocates/downloaded/rec8zXNiryVq3Q6kh.jpg",
         region: "America (North)",
         city: "New York",
-        country: ["United States"],
+        country: "United States",
         slackId: "U017XULSMUY",
         slackUsername: "John.Doe",
       },
@@ -31,7 +31,7 @@ describe("writeJSONToFile", () => {
         image: "/images/advocates/downloaded/recFKAk7KoXr3IMTH.jpg",
         region: "America (North)",
         city: "Durham",
-        country: ["United States"],
+        country: "United States",
         slackId: "U01313A0AGP",
         slackUsername: "J.Doe",
       },
@@ -62,7 +62,7 @@ describe("writeJSONToFile", () => {
         image: "/images/advocates/downloaded/rec8zXNiryVq3Q6kh.jpg",
         region: "America (North)",
         city: "New York",
-        country: ["United States"],
+        country: "United States",
         slackId: "U017XULSMUY",
         slackUsername: "J.Doe",
       },
@@ -71,7 +71,7 @@ describe("writeJSONToFile", () => {
         image: "/images/advocates/downloaded/recFKAk7KoXr3IMTH.jpg",
         region: "America (North)",
         city: "Durham",
-        country: ["United States"],
+        country: "United States",
         slackId: "U01313A0AGP",
         slackUsername: "John.Doe",
       },

diff --git a/types/advocates.ts b/types/advocates.ts
@@ -16,7 +16,7 @@ const ADVOCATES_WORLD_REGION_OPTIONS = Object.values(
 
 interface Advocate {
   city: string;
-  country: string[];
+  country: string;
   image: string;
   location?: string;
   name: string;