Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align QPY version with service #136

Merged
merged 12 commits into from
Dec 9, 2024
Merged

Align QPY version with service #136

merged 12 commits into from
Dec 9, 2024

Conversation

jesus-talavera-ibm
Copy link
Contributor

@jesus-talavera-ibm jesus-talavera-ibm commented Dec 2, 2024

Summary

In order to prevent this kind of errors when exchanging circuits with service:

'Error loading circuit qpy_circuits: "The QPY format version being read, 13, isn\'t supported by this Qiskit version. Please upgrade your version of Qiskit to load this QPY payload". Please, review your inputs'

We need to align QPY versions between client and service

Details and comments

@jesus-talavera-ibm jesus-talavera-ibm self-assigned this Dec 2, 2024
@mtreinish
Copy link
Member

The better approach for this would be to add an API server side to report the max qpy version supported. Then the client query this and could do basic version negotiation and send the appropriate version. I explained what this would look like in some detail here: Qiskit/qiskit-ibm-runtime#1375

@jesus-talavera-ibm
Copy link
Contributor Author

The better approach for this would be to add an API server side to report the max qpy version supported. Then the client query this and could do basic version negotiation and send the appropriate version. I explained what this would look like in some detail here: Qiskit/qiskit-ibm-runtime#1375

Thank you @mtreinish That's a good idea!

@jesus-talavera-ibm jesus-talavera-ibm changed the title Force qpy to use version 12 Align QPY version with service Dec 3, 2024
@jesus-talavera-ibm jesus-talavera-ibm marked this pull request as ready for review December 4, 2024 13:45
Copy link
Collaborator

@victor-villar victor-villar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
I have a minor comment on how to call qpy.dump.

qiskit_ibm_transpiler/utils.py Outdated Show resolved Hide resolved
victor-villar
victor-villar previously approved these changes Dec 5, 2024
victor-villar
victor-villar previously approved these changes Dec 9, 2024
Copy link
Collaborator

@victor-villar victor-villar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jesus-talavera-ibm jesus-talavera-ibm merged commit 4c1d030 into main Dec 9, 2024
2 of 4 checks passed
@jesus-talavera-ibm jesus-talavera-ibm deleted the jt-use-qpy-12 branch December 9, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants