-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align QPY version with service #136
Conversation
The better approach for this would be to add an API server side to report the max qpy version supported. Then the client query this and could do basic version negotiation and send the appropriate version. I explained what this would look like in some detail here: Qiskit/qiskit-ibm-runtime#1375 |
Thank you @mtreinish That's a good idea! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I have a minor comment on how to call qpy.dump
.
Co-authored-by: victor-villar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary
In order to prevent this kind of errors when exchanging circuits with service:
We need to align QPY versions between client and service
Details and comments