Task support in v2 primitives #1224

jyu00 · 2023-11-16T21:35:58Z

Summary

Support tasks in v2 primitives.

Details and comments

Fixes #

* add options * fix mypy * rename meas err mit * Add additional resilience options * Add additional execution options for twirling * A twirling strategy option and validation * handle default resilience options * add _experimental * Update default resilience options (Qiskit#1062) * remove default resilience options * add reno * add logic to override default * add test * purge None values from options (cherry picked from commit 76603f2) * add finalize options * add tests * Update qiskit_ibm_runtime/options/resilience_options.py * add validation * lint * lint again * lint again * Allow None values for specific options to be passed through * Fix parameter validation, allow computational basis * black * Fix ZneExtrapolatorType validation * lint * lint again * fix mypy * Fix ZNE extrapolator default option * fix level options * black * use _isreal * Disable gate twirling for default lvl 1 opts * Support for legacy options --------- Co-authored-by: Christopher J. Wood <[email protected]> Co-authored-by: Kevin Tian <[email protected]> Co-authored-by: mberna <[email protected]> Co-authored-by: Mariana C Bernagozzi <[email protected]>

…nto estimator_v2

…ntime into estimator_v2

* Remove min execution time check (Qiskit#1065) * Remove min execution time check * update unit test * remove integration test * Update `max_execution_time` docstrings (Qiskit#1059) * Update max_execution_time docstrings * add commas * Update qiskit_ibm_runtime/options/options.py Co-authored-by: Rebecca Dimock <[email protected]> * Update qiskit_ibm_runtime/options/options.py Co-authored-by: Rebecca Dimock <[email protected]> * Update qiskit_ibm_runtime/runtime_options.py Co-authored-by: Rebecca Dimock <[email protected]> * Update releasenotes/notes/max-execution-time-definition-196cb6297693c0f2.yaml Co-authored-by: Rebecca Dimock <[email protected]> --------- Co-authored-by: Rebecca Dimock <[email protected]> * Removed remaining code related to Schedules (Qiskit#1068) Co-authored-by: Kevin Tian <[email protected]> * Enable datetime parameter for backend properties (Qiskit#1070) * enable datetime param for backend properties * add test & reno * improve test * Update default resilience options (Qiskit#1062) * remove default resilience options * add reno * add logic to override default * add test * purge None values from options * fix test (Qiskit#1074) * Prepare release 0.12.1 (Qiskit#1075) * Update main branch veresion 0.12.2 (Qiskit#1076) * use ibmq_qasm_simulator (Qiskit#1078) * Add reason code to error message (Qiskit#1072) * Add reason code to error message * add reno * Remove importing PauliSumOp, which is deprecated. (Qiskit#1079) --------- Co-authored-by: Jake Lishman <[email protected]> Co-authored-by: Kevin Tian <[email protected]> * Adjusts default value for optimization_level (Qiskit#1082) * add instance info (Qiskit#1083) * add instance info * Add cloud note * Update README.md Co-authored-by: Kevin Tian <[email protected]> --------- Co-authored-by: Kevin Tian <[email protected]> * Fix links to options in README.md (Qiskit#1084) * Remove auth parameter (Qiskit#1077) * Removed auth parameter * Removed calls to migrate() * black and lint --------- Co-authored-by: Kevin Tian <[email protected]> * Remove opflow and algorithms from serialization tests (Qiskit#1085) * Remove opflow from tests * Re-add test for PauliSumOp * Fix lint * Fix black --------- Co-authored-by: Kevin Tian <[email protected]> * RuntimeJobTimeoutError should inherit from JobTimeoutError (Qiskit#1090) * RuntimeJobTimeoutError inherits from JobTimeoutError * black --------- Co-authored-by: Kevin Tian <[email protected]> * Allow user to define a default account as an environment variable (Qiskit#1018) * Allow user to define a default account as an environment variable * Fixed test * Fixed mistaken paste * Cleaned up test * Moved test to TestAccountManager * Added ability to define default channel in save_account * Cleaned up code, fixed bugs * Changed name of parameter * Added test. Cleaned up code surrounding preferences of channel selection * black and lint * Fixed bug when json file was empty * Code cleanup and documentation * Documentation * Removed channel from condition, because unnecessary * changed default_channel to default_account * Changed saving and getting default channel to default account * black * Documentation * Release notes * Reverted diff that was unnecessary --------- Co-authored-by: Kevin Tian <[email protected]> * Skip test_job_logs (Qiskit#1094) * Update session max_time docstring (Qiskit#1089) * Update session max_time docstring * Update qiskit_ibm_runtime/session.py Co-authored-by: Rebecca Dimock <[email protected]> --------- Co-authored-by: Rebecca Dimock <[email protected]> * Fix unit tests against qiskit/main (Qiskit#1099) * Add measurements to sampler * Remove observables from sampler run --------- Co-authored-by: Kevin Tian <[email protected]> * fix iqp link (Qiskit#1096) Co-authored-by: Kevin Tian <[email protected]> * Only return channel strategy supported backends (Qiskit#1095) * Q-CTRL Backend filters * add reno * fix unit tests * Attempt to fix terra unit tests (Qiskit#1102) * Attempt to fix terra unit tests * test on my fork * revert coder_qc change * Making account code more generic (Qiskit#1060) * Making account code more generic by defining subclasses for channel types * Removed channel parameter from _assert_valid_instance * mypy, lint and black * Changed order of decorators * Code cleanup * Documentation fixes * black --------- Co-authored-by: Kevin Tian <[email protected]> * Remove old deprecations (Qiskit#1106) * removing old deprecations * update unit tests * Open plan updates (Qiskit#1105) * Initial edits * edit * Update docs/faqs/max_execution_time.rst * Update docs/faqs/max_execution_time.rst * Update docs/faqs/max_execution_time.rst * Update docs/faqs/max_execution_time.rst * Update docs/faqs/max_execution_time.rst * Update docs/faqs/max_execution_time.rst Co-authored-by: Jessie Yu <[email protected]> * Jessie comments * Update docs/faqs/max_execution_time.rst Co-authored-by: Jessie Yu <[email protected]> * Update docs/faqs/max_execution_time.rst Co-authored-by: Jessie Yu <[email protected]> * Update docs/sessions.rst * Update docs/faqs/max_execution_time.rst --------- Co-authored-by: Jessie Yu <[email protected]> * New method to create a new Session object with a given id (Qiskit#1101) * Added the Session.from_id method * release notes * Added integration test --------- Co-authored-by: Kevin Tian <[email protected]> * fix test_session_from_id (Qiskit#1110) * Warn users if job submitted will exceed quota (Qiskit#1100) * Warn users if job will exceed quota * update reno * update reno again * Removed support for backend as session parameter (Qiskit#1091) Co-authored-by: Kevin Tian <[email protected]> * Fix minor todos (Qiskit#1112) * Change qpu complex wording (Qiskit#1109) * Don't use QPU complex * don't use the word 'limit' * Update docs/faqs/max_execution_time.rst * Update qiskit_ibm_runtime/options/options.py * Update qiskit_ibm_runtime/runtime_job.py * Update releasenotes/notes/0.11/job-cost-estimation-d0ba83dbc95c3f67.yaml * Clarify usage * reclarify reset time * rogue comma * fix whitespace & formatting * job -> system execution time --------- Co-authored-by: Kevin Tian <[email protected]> * Add IBM Cloud channel (Qiskit#1113) * Changes for Qiskit#1806 * Update docs/faqs/max_execution_time.rst Co-authored-by: Jessie Yu <[email protected]> --------- Co-authored-by: Kevin Tian <[email protected]> Co-authored-by: Jessie Yu <[email protected]> Co-authored-by: Kevin Tian <[email protected]> * Prepare release 0.12.2 (Qiskit#1115) * Update main branch 0.13.0 (Qiskit#1116) * remove error message test (Qiskit#1125) * Exceptions should inherit from Terra where suitable (Qiskit#1120) * Changed RuntimeJobFailureError to inherit from JobError * Changed error type --------- Co-authored-by: Kevin Tian <[email protected]> * update docstring & remove max_time (Qiskit#1137) * Expose new session details (Qiskit#1119) * add session details method * add reno * support iqp urls * update details mehotd, add status() * update status() to use enum * revert previous change, wait for impl details * update fields returned * update status method * update docstring & reno * update docstrings for both methods * fix docs build * address comments * fix docs build * fix typo * docs build again * fix indent * fix indent again * fix indent 3rd time * Support only LocalFoldingAmplifier as noise_amplifier option (Qiskit#1093) * Removed support for all noise_amplifier options other than LocalFoldingAmplifier. Removed deprecation warning. * Removed tests that covered deprecation. Updated documentation --------- Co-authored-by: Kevin Tian <[email protected]> * Fix target_history date bug (Qiskit#1143) * fix target_history datetime bug * add reno * add test * Fixed bug when defining shots as int64 (Qiskit#1151) * Log instance on initialization and when running a job (Qiskit#1150) * log instances * add _default_instance & fix lint * add test * change var name to current_instance * Move methods into class pages for docs (Qiskit#1144) * Fix link to `Close a session` (Qiskit#1152) [1] links to [2] but doesn't go directly to the target section. [1] https://qiskit.org/ecosystem/ibm-runtime/sessions.html#what-happens-when-a-session-ends [2] https://qiskit.org/ecosystem/ibm-runtime/how_to/run_session.html#close-a-session Co-authored-by: Kevin Tian <[email protected]> * logging instance test is IQP channel only (Qiskit#1154) * Update deploy yml (Qiskit#1148) * Allow users to indicate they are done submitting jobs to a session (Qiskit#1139) * copy changes over * clean up branch again * address comments, update docstrings * catch appropriate error code * update status code to 404 * Update qiskit_ibm_runtime/session.py Co-authored-by: Jessie Yu <[email protected]> * set self._active & remove runtime_session * Update releasenotes/notes/session-accepting-jobs-d7ef6b60c0f5527b.yaml Co-authored-by: Jessie Yu <[email protected]> --------- Co-authored-by: Jessie Yu <[email protected]> * Prepare release 0.13 (Qiskit#1157) * Update main branch 0.13.1 (Qiskit#1158) * Update Sphinx theme (Qiskit#1156) Co-authored-by: Kevin Tian <[email protected]> * Added IBM Quantum logo (Qiskit#1164) * sessions changes (Qiskit#1169) * sessions changes * add more ticks * fix link * fix links * Update docs/sessions.rst Co-authored-by: abbycross <[email protected]> * Update docs/sessions.rst Co-authored-by: abbycross <[email protected]> --------- Co-authored-by: abbycross <[email protected]> * Disallow unsupported options (Qiskit#1108) * Disallow unsupported options * Moved checking of unsupported options to 'flexible' decorator * Modified the test to give TypeError where needed * Removed empty newline * Moved tests from test_ibm_primitives to test_options, because they don't require a primitive * typo * Release note * black and lint * black again * Fixed test failing in CI * Removed _flexible decorator. Moved _post_init into Options class * lint * lint * Fixed bug * lint --------- Co-authored-by: Kevin Tian <[email protected]> * fix merge issues * black * lint --------- Co-authored-by: Kevin Tian <[email protected]> Co-authored-by: Rebecca Dimock <[email protected]> Co-authored-by: merav-aharoni <[email protected]> Co-authored-by: Luciano Bello <[email protected]> Co-authored-by: Jake Lishman <[email protected]> Co-authored-by: Esteban Ginez <[email protected]> Co-authored-by: Kevin Tian <[email protected]> Co-authored-by: mberna <[email protected]> Co-authored-by: Elena Peña Tapia <[email protected]> Co-authored-by: Arnau Casau <[email protected]> Co-authored-by: Matt Riedemann <[email protected]> Co-authored-by: abbycross <[email protected]>

…untime into options_v2

into sampler_options_v2

…bm-runtime into sampler_options_v2

…ibm-runtime into estimatorv2_tasks

…bm-runtime into estimatorv2_tasks

coveralls · 2023-11-28T22:53:03Z

Pull Request Test Coverage Report for Build 7034996942

487 of 639 (76.21%) changed or added relevant lines in 32 files are covered.
21 unchanged lines in 4 files lost coverage.
Overall coverage increased (+0.3%) to 60.315%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
qiskit_ibm_runtime/base_primitive.py	23	24	95.83%
qiskit_ibm_runtime/options/utils.py	0	1	0.0%
qiskit_ibm_runtime/qiskit/primitives/base_estimator.py	18	19	94.74%
qiskit_ibm_runtime/qiskit/primitives/base_task.py	10	11	90.91%
qiskit_ibm_runtime/qiskit/primitives/options.py	12	14	85.71%
qiskit_ibm_runtime/sampler.py	3	5	60.0%
qiskit_ibm_runtime/utils/json.py	29	31	93.55%
qiskit_ibm_runtime/runtime_job.py	5	8	62.5%
qiskit_ibm_runtime/qiskit/primitives/estimator_task.py	36	40	90.0%
qiskit_ibm_runtime/qiskit/primitives/object_array.py	27	31	87.1%

Files with Coverage Reduction	New Missed Lines	%
qiskit_ibm_runtime/utils/estimator_result_decoder.py	1	52.63%
qiskit_ibm_runtime/sampler.py	5	88.33%
qiskit_ibm_runtime/utils/deprecation.py	7	0.0%
qiskit_ibm_runtime/qiskit/primitives/utils.py	8	0.0%

Totals
Change from base Build 6896503960:	0.3%
Covered Lines:	3254
Relevant Lines:	5395

💛 - Coveralls

jyu00 and others added 30 commits September 20, 2023 18:44

Merge branch 'main' of https://github.com/Qiskit/qiskit-ibm-runtime i…

cf0d816

…nto estimator_v2

fix merge issues

989a321

add pydantic

5ab8a93

black

11c30cc

lint

e6ef47f

Merge branch 'fast_forward' of https://github.com/jyu00/qiskit-ibm-ru…

e998b81

…ntime into estimator_v2

v2 options

b5c7100

estimator options

3671b46

update test

bf5a677

lint

1d4b36e

Merge branch 'experimental' of https://github.com/Qiskit/qiskit-ibm-r…

1790d63

…untime into options_v2

fix merge issues

4198fad

black

9c3e359

fix noise model type

4ec1b9e

lint again

3c9261c

fix header

6369191

fix mypy

548005a

use v2 as default

d05ce59

cleanup terra options

6745067

black

7370b5d

options need not be callable

a19ccd4

fix doc

52febc9

fix tests

b29a4e5

fix version

1f8bd7c

add sampler option

027e6ca

lint

260f7c8

freeze constants

a56cdf0

Merge branch 'options_v2' of https://github.com/jyu00/qiskit-ibm-runtime

5574264

into sampler_options_v2

jyu00 added 15 commits November 16, 2023 13:42

add seed_estimator

17c3fb7

Merge branch 'experimental-0.2' of https://github.com/Qiskit/qiskit-i…

4c96863

…bm-runtime into sampler_options_v2

resolve merge issues

ab493e5

Merge branch 'sampler_options_v2' of https://github.com/jyu00/qiskit-…

cea49a5

…ibm-runtime into estimatorv2_tasks

update docstring

18ee2bb

Merge branch 'experimental-0.2' of https://github.com/Qiskit/qiskit-i…

1b9a037

…bm-runtime into estimatorv2_tasks

lint

8928d9b

3.8 mapping

85b4192

v2 result

14112fe

estimator result version

e2ddeb3

line

7e77f3f

3.8 support

beac510

also 3.8 support

99af6cf

fix tests with no inputs

a6bf0b2

fix version passing

b310c02

jyu00 added 4 commits November 29, 2023 10:14

fix decoder param

23c0f4a

disable samplerv2

320f2f6

disable samplerv2 tests

b9e68a6

lint

9c1b6c9

jyu00 marked this pull request as ready for review November 29, 2023 16:00

jyu00 requested review from mberna and kt474 November 29, 2023 16:01

kt474 approved these changes Nov 29, 2023

View reviewed changes

mberna approved these changes Nov 29, 2023

View reviewed changes

jyu00 merged commit 73b3385 into Qiskit:experimental-0.2 Nov 29, 2023
17 checks passed

jyu00 deleted the estimatorv2_tasks branch November 29, 2023 18:48

kt474 mentioned this pull request Jan 5, 2024

Primitive interface updates #1131

Closed

3 tasks

This was referenced Jan 17, 2024

Primitive interface updates for EstimatorV2 #1314

Closed

Primitive interface updates for SamplerV2 #1313

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Task support in v2 primitives #1224

Task support in v2 primitives #1224

jyu00 commented Nov 16, 2023

coveralls commented Nov 28, 2023 •

edited

Loading

Task support in v2 primitives #1224

Task support in v2 primitives #1224

Conversation

jyu00 commented Nov 16, 2023

Summary

Details and comments

coveralls commented Nov 28, 2023 • edited Loading

Pull Request Test Coverage Report for Build 7034996942

💛 - Coveralls

coveralls commented Nov 28, 2023 •

edited

Loading