From fec9aa23c96b9b17b990eb2316b203403d31ccbe Mon Sep 17 00:00:00 2001 From: Juan Cruz-Benito Date: Thu, 25 Oct 2018 17:17:52 +0200 Subject: [PATCH 1/2] Changing update modal behavior: the package will be only updated if the user clicks OK explicitly. --- client/src/packages/packageManager.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/client/src/packages/packageManager.ts b/client/src/packages/packageManager.ts index 4892fbb..b8b65e8 100644 --- a/client/src/packages/packageManager.ts +++ b/client/src/packages/packageManager.ts @@ -126,8 +126,8 @@ export class PackageManager { QLogger.verbose(`Clicked on Dismiss!`, this); return false; } else { - QLogger.verbose(`Clicked on other element! Updating anyway...`, this); - return true; + QLogger.verbose(`Clicked on another element! Cancelling update`, this); + return false; } } From 7b91b283c33c8cea33fb0abdf6764a0a9b5cb620 Mon Sep 17 00:00:00 2001 From: Juan Cruz-Benito Date: Thu, 25 Oct 2018 17:20:42 +0200 Subject: [PATCH 2/2] Adding PR #45 to the CHANGELOG --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index ac49e86..c163ac4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -19,6 +19,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. ### 🎉 Added ### 🐛 Fixed +- Changing update packages modal behavior: they must be only updated if the user clicks OK explicitly ([#45](https://github.com/Qiskit/qiskit-vscode/pull/45) by [@cbjuan](https://github.com/cbjuan)) ### ✏️ Changed