Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force hamming_left and hamming_right to be kwargs throughout API #16

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Force hamming_left and hamming_right to be kwargs throughout API #16

merged 3 commits into from
Sep 13, 2024

Conversation

caleb-johnson
Copy link
Collaborator

@caleb-johnson caleb-johnson commented Sep 13, 2024 •
edited
Loading

This PR forces all functions which take hamming_left and hamming_right as positional args to instead take them as keyword args. This PR also forces the num_batches and samples_per_batch kwargs of postselect_and_subsample to be kwargs.

@caleb-johnson caleb-johnson merged commit 147405a into main Sep 13, 2024
7 of 8 checks passed
@caleb-johnson caleb-johnson deleted the hamming-kwargs branch September 13, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinsung kevinsung kevinsung requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caleb-johnson @kevinsung