Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing information in error message on dumping benchmark records #132

Open
jusschwitalla opened this issue Aug 16, 2024 · 0 comments
Open

Comments

@jusschwitalla
Copy link
Contributor

If some data are written to metrics (self.metrics.add_metric) which are not json representable an error occurs when the BenchmarkManager tries to write the results.json. For example: "TypeError: Object of type Graph is not JSON serializable"
The problem now is that it can be very hard to find the responsible add_metric call.
It would be very helpfull if the error message would contain the information which attribute it is that cannot be written.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant