Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embedded dependencies workflow #165

Merged
merged 10 commits into from
Oct 14, 2020
Merged

Embedded dependencies workflow #165

merged 10 commits into from
Oct 14, 2020

Conversation

Guts
Copy link
Contributor

@Guts Guts commented Oct 13, 2020 •
edited by havatv
Loading

Description

With this PR, I propose to close #166 with a development workflow allowing:

  • integration with Dependabot (https://app.dependabot.com/) to track updates from embedded external libs
  • update the 3 external libs to their latest versions
  • later: remove the libs from this git repository, expecting from the developers of this plugin use the workflow (pip install)
  • later: use the CI to automatically test against new versions
  • later: use the CI to package the plugin with ugraded versions
  • misc: connect to the dependency graphs like Github or libraries.io, displaying thanks and love to libs authors 🥰

The workflow is described in a specific doc page: https://github.com/QGIS-Contribution/QGIS-ResourceSharing/blob/42e481d86ef4d4b27f6592a12ad8d4468cbdbf71/docs/development/update_dependencies.md

Changes

  • create a requirements file referencing the external packages
  • document development workflow
  • remove raw external libs from the repotisory
  • move the ext_libs folder as a plugin subfolder

havatv
havatv approved these changes Oct 13, 2020
View reviewed changes
Copy link
Collaborator

@havatv havatv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.Thanks!
It would be nice to ave an issue for this - could you create one, @Guts?

@Guts
Copy link
Contributor Author

Guts commented Oct 14, 2020

It would be nice to ave an issue for this - could you create one, @Guts?

Done. Tell me if that's ok.

remove raw external libs from the repository

I've added this step. I was thinking it's better to completely remove the raw external code from this repository. What do you think?

Additional question: is the gitter chan still in use?

@havatv
Copy link
Collaborator

havatv commented Oct 14, 2020

It would be nice to ave an issue for this - could you create one, @Guts?

Done. Tell me if that's ok.

Looks perfect.Thanks.

@havatv havatv merged commit 8f82646 into QGIS-Contribution:master Oct 14, 2020
@Guts Guts mentioned this pull request Oct 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@havatv havatv havatv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the integration of external libraries
2 participants
@Guts @havatv