-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More automated way to add an event #17
Comments
not sure I follow. |
<li>
<div class="event__info">
<span id="edate">10/05/2020</span>
<span>
Qiskit Hackathon Global <a href="https://qiskithackathon.global.bemyapp.com/#/event">[link]</a>
</span>
</div>
</li>
<li>
<div class="event__info">
<span id="edate">09/29/2020</span>
<span>
UCI Virtual Booth <a href="https://www.google.com/calendar/event?eid=ODJ2ZmRwNmhjMTg4bGNiZzVkbGN1NW5rNjAgY192Y2ZhcjJqM3JtYThqZXJxc3JncTFnZThzOEBn&ctz=America/Los_Angeles">[link]</a>
</span>
</div>
</li> 👆2 event entries.
Makes sense? |
That part I get, yes. The thing that was not clear for me is how to add mustaches. |
I haven't tried mustaches. But based on this stackoverflow answer I think it is doable in our case. We might even be able to make the event a separate json/csv file to load into the template! |
I understand that it could be doable, but for me personally it would take much more time studying handlebars or mustache and figuring out how to implement it in our case, rather than just copying pre formatted 8 lines of code. |
To be clear, I am not suggesting mustaches should be the preferred way. It is just the idea of keeping data and code separate prompts me to look for a component/template engine since frontend framework like React has heavy focus on re-usable component. Also, it could open up workflow like google sheet -> json -> event.html. Yeah, it is a quality of life feature with low priority. |
@all-contributors please add @TDHTTTT for code, bug |
I've put up a pull request to add @TDHTTTT! 🎉 |
When adding a new event to the event.html, I found 2 potential issues (which of course can be avoided with some labor):
Edit: For 1, it would be awesome if we can extract all the data part from the event into a database (e.g. json) and load it using js. The separate code, database makes it cleaner and easier to maintain imo.
The text was updated successfully, but these errors were encountered: