Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid type hinting in initial_channels #460

Open
junah201 opened this issue Jul 2, 2024 · 1 comment · May be fixed by #461
Open

Invalid type hinting in initial_channels #460

junah201 opened this issue Jul 2, 2024 · 1 comment · May be fixed by #461

Comments

@junah201
Copy link

junah201 commented Jul 2, 2024

I was just curious about TwitchIO's internal code implementation and happened to stumble upon an incorrect type hint.

The type of initial_channels in WSConnection is actually Union[list, tuple, Callable], but it is List[str].
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024

Hello! Thanks for the issue. If this is a general help question, for a faster response consider joining the official Discord Server

Else if you have an issue with the library please wait for someone to help you here.

junah201 added a commit to junah201/TwitchIO that referenced this issue Jul 2, 2024
@junah201
Fix invalid type hinting of initial_channels in WS Connection (Python…
bd20ae7 
…istaGuild#460)
@junah201 junah201 linked a pull request Jul 2, 2024 that will close this issue
Open
8 tasks
junah201 added a commit to junah201/TwitchIO that referenced this issue Jul 2, 2024
@junah201
Fix invalid type hinting of initial_channels in WS Connection (Python…
0f36b0b 
…istaGuild#460)
junah201 added a commit to junah201/TwitchIO that referenced this issue Jul 3, 2024
@junah201
Fix invalid type hinting of initial_channels in WS Connection (Python…
fe807b3 
…istaGuild#460)
junah201 added a commit to junah201/TwitchIO that referenced this issue Jul 3, 2024
@junah201
Fix invalid type hinting of initial_channels in WS Connection (Python…
a0c0193 
…istaGuild#460)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix invalid type hinting of initial_channels in WS Connection junah201/TwitchIO
1 participant
@junah201