[Opta] fix deflected pass end coordinates and result #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@probberechts Could you please also have a look at this pull request? Thank you! |
|
@koenvo added the comment, but checks seems to be failing due to unrelated issue: https://github.com/PySport/kloppy/actions/runs/9064091328/job/24901521491 |
|
Can you please merg master in to make sure the tests run |
4 tasks
|
A painful merge conflict to resolve due to the refactoring of the statsperform parser 😅 , but this one should be ready to merge as well @koenvo! |
|
Oh no. Again merge conflicts :-( |
…nates # Conflicts: # kloppy/infra/serializers/event/statsperform/deserializer.py # kloppy/tests/test_adapter.py # kloppy/tests/test_opta.py
|
resolved them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue described in: #274