Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Wyscout orientation #279

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Fix Wyscout orientation #279

merged 2 commits into from
Jan 22, 2024

Conversation

DriesDeprest
Copy link
Contributor

Wyscout v2 and v3 have ACTION_EXECUTING_TEAM as orientation. See issue #236 for context.

@JanVanHaaren
Copy link
Collaborator

Thanks! Would it be possible to add some tests to prevent this functionality from breaking in the future?

JanVanHaaren
JanVanHaaren approved these changes Jan 14, 2024
View reviewed changes
Copy link
Collaborator

@JanVanHaaren JanVanHaaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@koenvo koenvo added this to the 3.15 milestone Jan 22, 2024
@koenvo koenvo merged commit 6013893 into PySport:master Jan 22, 2024
19 checks passed
@fubininho fubininho mentioned this pull request May 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanVanHaaren JanVanHaaren JanVanHaaren approved these changes

Assignees

@koenvo koenvo

Labels
None yet
Projects
None yet
Milestone
3.15
Development

Successfully merging this pull request may close these issues.
3 participants
@DriesDeprest @JanVanHaaren @koenvo