Add artificial formation change event in Wyscout deserializer #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koenvo
reviewed
Dec 8, 2023
| ) in event_formation_change_info.items(): | ||
| generic_event_args.update( | ||
| { | ||
| "event_id": None, |
There was a problem hiding this comment.
It would be good to give this event an id. I checked the Metrica implementation which also creates synthetic events and it seems it's reusing the original event id.
The eventIds should be unique over a match. Maybe you can add a prefix to the original eventId and use that one?
And would be good to use the term 'synthetic' instead of 'artificial'.
koenvo
reviewed
Dec 8, 2023
| @@ -56,6 +56,10 @@ def test_correct_v3_deserialization(self, event_v3_data: Path): | |||
| ) | |||
| assert dataset.events[9].event_type == EventType.CLEARANCE | |||
| assert dataset.events[12].event_type == EventType.INTERCEPTION | |||
| assert ( | |||
koenvo
reviewed
Dec 8, 2023
| event["opponentTeam"]["formation"] | ||
| ] | ||
| else: | ||
| raise DeserializationError(f"Unknown team_id {team.team_id}") |
There was a problem hiding this comment.
Great to see you used this existing exception.
JanVanHaaren
approved these changes
Dec 10, 2023
|
Thanks! I merged all aproved PR's so far. This caused a merge conflict in this PR. Can you please merge master in this branch? When the conflict is resolved I'll merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #243