Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracab with string path not working #305

Closed
koenvo opened this issue Apr 4, 2024 · 1 comment
Closed

Tracab with string path not working #305

koenvo opened this issue Apr 4, 2024 · 1 comment

Comments

@koenvo
Copy link
Contributor

koenvo commented Apr 4, 2024

          I've noticed a small bug in this PR. Kloppy allows specifying the data source as a `FileLike` object but now it only works with a `Path`. For example with a string:
from kloppy import tracab

dataset = tracab.load(
    meta_data="kloppy/tests/files/tracab_meta.xml",
    raw_data="kloppy/tests/files/tracab_raw.dat",
)

It gives the following error: AttributeError: 'str' object has no attribute 'name'

Originally posted by @probberechts in #295 (comment)

@koenvo
Copy link
Contributor Author

koenvo commented Oct 22, 2024

Fixed in #306

@koenvo koenvo closed this as completed Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant