make PySliceContainer implement Sync
#469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no suggestions.
Merged
davidhewitt
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
I agree. cc @ngoldbaum, I wonder if you have opinions on this?
src/slice_container.rs
Outdated
Comment on lines
16
to
24
| unsafe impl Send for PySliceContainer {} | ||
| unsafe impl Sync for PySliceContainer {} |
There was a problem hiding this comment.
Shall we add some // Safety comments here to justify (both) traits?
davidhewitt
approved these changes
Nov 19, 2024
|
Forgive my lack of context here: is |
|
Yes, exactly that, it'll usually be |
|
In that case yes I agree we should ensure T is Sync. |
|
Thank you both for taking a look. I'll go ahead an merge this then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepares for the
pyo3upgrade to 0.23 in #457.This contains two changes:
This implements
SyncforPySliceContainerwhich is used as the underlying backing object for Rust allocatednumpyarrays.Since
PySliceContainer"virtually" does hold elements of typeT(which is cast away due to the no-generics limitation), construction is only allowed fromTs that areSyncthemselves. (Ideally we would haveunsafe impl<T: Sync> Sync for PySliceContainer<T> {}).I think it will hand out references into that buffer in place, so we need to require all
Elements to beSyncas well. In any case I think this could only be too strong, which would not be unsound.