Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix chrono::DateTime<Tz> intoPyObject conversion #4790

Merged
merged 2 commits into from
Dec 12, 2024
Merged

fix chrono::DateTime<Tz> intoPyObject conversion #4790

merged 2 commits into from
Dec 12, 2024

Conversation

bschoenmaeckers
Copy link
Contributor

fixes #3266

Icxolu
Icxolu reviewed Dec 11, 2024
View reviewed changes
Copy link
Contributor

@Icxolu Icxolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me. Maybe we can add a test that a DateTime<chrono_tz::Tz> converts as expected? (I think we currently only have tests for DateTime<UTC> and DateTime<FixedOffset>)

src/conversions/chrono.rs Outdated Show resolved Hide resolved
@bschoenmaeckers bschoenmaeckers force-pushed the chrono-timezone branch 4 times, most recently from 42324a3 to 12ba32e Compare December 12, 2024 12:19
Icxolu
Icxolu approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@Icxolu Icxolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@Icxolu Icxolu added this pull request to the merge queue Dec 12, 2024
Merged via the queue into PyO3:main with commit 0777c6e Dec 12, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Icxolu Icxolu Icxolu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IntoPy does not properly respect chrono_tz::Tz timezones
2 participants
@bschoenmaeckers @Icxolu